Skip to content

lib.teams: Remove .githubTeams in favor of singular .github#449986

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
tweag:singular-github-teams
Oct 9, 2025
Merged

lib.teams: Remove .githubTeams in favor of singular .github#449986
wolfgangwalther merged 1 commit intoNixOS:masterfrom
tweag:singular-github-teams

Conversation

@infinisil
Copy link
Member

No team was using the feature of having multiple GitHub teams, and this would make it tricky to try to sync maintainer teams with GitHub teams, so let's switch teams to a singular list instead. This is a step towards #447514

It might be a bit overkill to do the entire deprecation dance for lib.teams.*.githubTeams, but I figured it won't hurt.

Tested with:

  • maintainers/scripts/feature-freeze-teams.pl
  • nix-build lib/tests/teams.nix

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: lib The Nixpkgs function library 6.topic: teams Relating to team creation, updates, other management actions labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from hsjobeki October 8, 2025 16:36
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 8, 2025
No team was using the feature of having multiple GitHub teams, and this
would make it tricky to try to sync maintainer teams with GitHub teams.
@infinisil infinisil force-pushed the singular-github-teams branch from a610a2b to 1ea51e1 Compare October 8, 2025 19:45
@infinisil infinisil changed the title lib.teams: Introduce singular .github to deprecate .githubTeams list lib.teams: Remove .githubTeams in favor of singular .github Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 8, 2025
@jopejoe1
Copy link
Member

jopejoe1 commented Oct 8, 2025

The feature freeze script would also need updating if this change gets merged.

Edit: Sorry, I was blind and missed the changes.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 9, 2025
@wolfgangwalther wolfgangwalther added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit 4d3f1e8 Oct 9, 2025
30 of 34 checks passed
@infinisil infinisil deleted the singular-github-teams branch October 9, 2025 09:23
@wolfgangwalther wolfgangwalther added the 8.has: port to stable This PR already has a backport to the stable release. label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: lib The Nixpkgs function library 6.topic: teams Relating to team creation, updates, other management actions 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants