Skip to content

gammu: add cmakeFlags for CMake >= 3.5#449950

Merged
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:gammu-fix
Oct 8, 2025
Merged

gammu: add cmakeFlags for CMake >= 3.5#449950
fabaff merged 2 commits intoNixOS:masterfrom
fabaff:gammu-fix

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 8, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
@fabaff
Copy link
Member Author

fabaff commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449950
Commit: 6e1508df7d7b4d0fd5c745b837e3f6a0b5ac0dc6


x86_64-linux

✅ 6 packages built:
  • gammu
  • home-assistant-component-tests.sms
  • python312Packages.python-gammu
  • python312Packages.python-gammu.dist
  • python313Packages.python-gammu
  • python313Packages.python-gammu.dist

@fabaff fabaff added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 442d27a Oct 8, 2025
30 of 34 checks passed
@fabaff fabaff deleted the gammu-fix branch October 8, 2025 19:14
@panchoh
Copy link
Contributor

panchoh commented Oct 9, 2025

Thanks for your efforts, @fabaff!

I see that somebody already mentioned this in some of your other recent PRs, but just for keeping this issue tracked, let me reiterate:

Please be aware of the recommendations offered in #445447 (especially point 3 at the top, further explained in @LordGrimmauld’s comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants