nixos/timesyncd: cleanup & make it bashless#449937
Merged
nikstur merged 2 commits intoNixOS:masterfrom Oct 10, 2025
Merged
Conversation
This workardoung is now unnecessary because systemd and systemd-timesyncd will never actually revert to a time lower than the current system time. It will only *advance* the system time to the EPOCH if the system time is lower. This also makes systemd-timesyncd bashless as we remove the preStart script for any NixOS version newer than 19.09.
Also remove the test that only tested this migration and nothing else about systemd-timesyncd.
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
arianvp
approved these changes
Oct 8, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Member
|
Contributor
|
Caused minor eval failure. Proposed the possible fix as: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split in two commits.
The first removes an unnecessary workaround:
The second removes an old migration for NixOS versions older than 19.09
Part of #428908
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.