Skip to content

libsignal-protocol-c: fix build with cmake 4#449924

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
wahjava:update/libsignal-protocol-c
Oct 8, 2025
Merged

libsignal-protocol-c: fix build with cmake 4#449924
SigmaSquadron merged 1 commit intoNixOS:masterfrom
wahjava:update/libsignal-protocol-c

Conversation

@wahjava
Copy link
Contributor

@wahjava wahjava commented Oct 8, 2025

This also unbreaks profanity

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from orivej October 8, 2025 13:13
@wahjava wahjava force-pushed the update/libsignal-protocol-c branch from 0de17ea to 62083ec Compare October 8, 2025 15:03
@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 837c848 Oct 8, 2025
27 of 31 checks passed
@panchoh
Copy link
Contributor

panchoh commented Oct 9, 2025

Hi, @wahjava, thanks for the fix!

Please be aware of the recommendations offered in #445447 (especially point 3 at the top, further explained in @LordGrimmauld’s comment), and update accordingly if applicable.

Cheers, Ashish 🖖.

@wahjava wahjava deleted the update/libsignal-protocol-c branch October 17, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants