Skip to content

teeworlds: fix for CMake v4#449899

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
nim65s:teeworld
Oct 13, 2025
Merged

teeworlds: fix for CMake v4#449899
Sigmanificient merged 1 commit intoNixOS:masterfrom
nim65s:teeworld

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Oct 8, 2025

ref. teeworlds/teeworlds#2821 merged upstream

part of #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from Luflosi October 8, 2025 12:36
@Luflosi
Copy link
Contributor

Luflosi commented Oct 9, 2025

Is there a reason why we can't fetchpatch2 teeworlds/teeworlds@23f3351 directly? I'm asking because I'm slightly concerned that we're not applying all the changes in that PR.

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449899
Commit: 9c0832b5d52afc97a6b26241ff99fbd666449273 (subsequent changes)
Merge: fc87b2d64502650933ca28136e3d499adef6cdd9

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18372291698


x86_64-linux

✅ 2 packages built:
  • teeworlds
  • teeworlds-server

aarch64-linux

✅ 2 packages built:
  • teeworlds
  • teeworlds-server

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • teeworlds
  • teeworlds-server

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • teeworlds
  • teeworlds-server

@nim65s
Copy link
Contributor Author

nim65s commented Oct 13, 2025

Is there a reason why we can't fetchpatch2 teeworlds/teeworlds@23f3351 directly? I'm asking because I'm slightly concerned that we're not applying all the changes in that PR.

My initial guess was that this commit would be too big to have a chance of clealy applying. I was wrong :)

Copy link
Contributor

@Luflosi Luflosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 13, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit 1db7b8c Oct 13, 2025
30 of 33 checks passed
nim65s added a commit to nim65s/dotfiles that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants