taskwarrior2: fix build with cmake 4#449892
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
|
nixpkgs-ci
bot
removed
the
12.first-time contribution
Add a proper patch that updates all CMakeLists.txt files to require CMake 3.10 instead of 3.0. This approach is preferred as it fixes the issue at the source and can be carried as a patch until merged upstream. Upstream PR: GothenburgBitFactory/taskwarrior#3969 Fixes: NixOS#449826 Signed-off-by: Dave Walker <[email protected]>
Daviey
force-pushed
the
fix/taskwarrior2-cmake4-build-failure
branch
from
a82cecb to
d8d17c9
Compare
drupol
left a comment
drupol
left a comment
There was a problem hiding this comment.
Instead of hosting the patch in nixpkgs, wouldn't it be a good idea to fetch the patches from upstream using fetchpatch instead ?
The upstream PRis not merged. You can't fetch unmerged PRs, bcause they may be garbage-collected after being force-pushed. |
How about the patches themselves. Each of them. |
that is exactly what is being done here? I am confused about what you want. |
|
I am closing this PR as it is a duplicate of #450177 |
4 participants
Fixes #449826
This patches the CMakeLists.txt files in taskwarrior to require CMake 3.10 instead of 3.0. CMake 4 doesn't support versions older than 3.5, and versions between 3.5-3.10 are deprecated.
The patch updates all 8 CMakeLists.txt files in the project (root, doc, performance, scripts, src, src/columns, src/commands, and test).
Upstream PR: GothenburgBitFactory/taskwarrior#3969
Tested by building the package and running the test suite on Linux.