Skip to content

libopenglrecorder: fix for CMake v4#449888

Merged
LordGrimmauld merged 2 commits intoNixOS:masterfrom
nim65s:openglrecorder
Oct 10, 2025
Merged

libopenglrecorder: fix for CMake v4#449888
LordGrimmauld merged 2 commits intoNixOS:masterfrom
nim65s:openglrecorder

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Oct 8, 2025

ref: Benau/libopenglrecorder#14

part of #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nim65s
Copy link
Contributor Author

nim65s commented Oct 8, 2025

Woops, I just saw #449352, sorry

@nim65s nim65s closed this Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from OPNA2608 October 8, 2025 12:12
@uninsane
Copy link
Contributor

hey this is actually the better fix than #449352 IMO. libopenglrecorder is using unstable- style versioning, and the bump from 2020-08-13 to 2025-10-07 is actually just a single commit (the cmake4 build fix commit) -- there looks to be 0 extra risk fixing this with a version update v.s. cherry picking.

i'll fixup #449352 while i'm here & let @OPNA2608 make the call though.

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449888
Commit: b28ea04f81c67361c4d253880ac8742fa5144765


aarch64-linux

❌ 1 package failed to build:
  • superTuxKart
✅ 1 package built:
  • libopenglrecorder

Error logs: `aarch64-linux`
superTuxKart
@nix { "action": "setPhase", "phase": "patchPhase" }
xargs: warning: options --max-args and -L are mutually exclusive, ignoring previous --max-args value
xargs: warning: options --max-lines and --replace/-I/-i are mutually exclusive, ignoring previous --max-lines value
substituteStream() in derivation supertuxkart-1.4: WARNING: '--replace' is deprecated, use --replace-{fail,warn,quiet}. (file 'CMakeLists.txt')
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/share/doc/SuperTuxKart -DCMAKE_INSTALL_INFODIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/include -DCMAKE_INSTALL_SBINDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/xkf154zsx1b2gmv5sz69yv7chp43341y-supertuxkart-1.4 -DBUILD_RECORDER=ON -DUSE_SYSTEM_ANGELSCRIPT=ON -DCHECK_ASSETS=OFF -DUSE_SYSTEM_WIIUSE=ON -DOpenGL_GL_PREFERENCE=GLVND
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.

Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

-- Configuring incomplete, errors occurred!

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @uninsane saying this is the better fix, i am inclined to agree and will merge this one over #449352.

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit 0037418 Oct 10, 2025
54 of 58 checks passed
@OPNA2608 OPNA2608 mentioned this pull request Oct 11, 2025
3 tasks
nim65s added a commit to nim65s/dotfiles that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants