Skip to content

maim: add cmake4 build support#449834

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
zarkone:maim-cmake4-fix
Oct 8, 2025
Merged

maim: add cmake4 build support#449834
sternenseemann merged 1 commit intoNixOS:masterfrom
zarkone:maim-cmake4-fix

Conversation

@zarkone
Copy link
Contributor

@zarkone zarkone commented Oct 8, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
@acid-bong
Copy link
Contributor

OP, note that we have local title conventions (apply for both commits and PRs). The correct format should be PROGRAM: CHANGES, if you're editing a package, or nixos/PROGRAM: CHANGES, if it's a NixOS module.

See more in the contributing docs.

May git commit --amend, git rebase -i and git push --force-with-lease be with you 🖖

@Kranzes
Copy link
Member

Kranzes commented Oct 8, 2025

This is not needed with #449283 being merged.

@Kranzes Kranzes closed this Oct 8, 2025
@Kranzes
Copy link
Member

Kranzes commented Oct 8, 2025

Hold on, the build is no longer failing, but you plan on bumping it for the future support?

@Kranzes Kranzes reopened this Oct 8, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449834
Commit: a4e287bd54a6e691ea52835323ff4e533331e6d9 (subsequent changes)
Merge: 01905e75e3d422fdf98e2cacc6f4a73786c7d93f

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18341463901


x86_64-linux

✅ 3 packages built:
  • maim
  • pb_cli
  • yaxg

aarch64-linux

✅ 3 packages built:
  • maim
  • pb_cli
  • yaxg

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 8, 2025
@zarkone
Copy link
Contributor Author

zarkone commented Oct 8, 2025

@acid-bong done! 🙏

OP, note that we have local title conventions (apply for both commits and PRs). The correct format should be PROGRAM: CHANGES, if you're editing a package, or nixos/PROGRAM: CHANGES, if it's a NixOS module.

See more in the contributing docs.

May git commit --amend, git rebase -i and git push --force-with-lease be with you 🖖

@Kranzes Kranzes changed the title fix maim cmake4 build maim: add cmake4 build support Oct 8, 2025
@sternenseemann sternenseemann added this pull request to the merge queue Oct 8, 2025
@sternenseemann
Copy link
Member

If you have the time, you can propose an equivalent change upstream as a PR to maim. IME they are responsive and so we may be able to replace this hack by fetching a patch soon!

Merged via the queue into NixOS:master with commit 27a74bf Oct 8, 2025
28 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants