Skip to content

ledger: fix cmake 4 compatibility#449829

Merged
kirillrdy merged 3 commits intoNixOS:masterfrom
GaetanLepage:ledger
Oct 8, 2025
Merged

ledger: fix cmake 4 compatibility#449829
kirillrdy merged 3 commits intoNixOS:masterfrom
GaetanLepage:ledger

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Oct 8, 2025 •
edited
Loading

Things done

  • ledger: modernize
  • ledger: fix cmake 4 compatibility
  • ledger-autosync: skip failing tests on darwin

cc @jwiegley

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

GaetanLepage added a commit to nix-community/nixvim that referenced this pull request Oct 8, 2025
@GaetanLepage
tests/dependencies: disable ledger (build failure)
ae4d502 
Fixed in NixOS/nixpkgs#449829
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from jwiegley October 8, 2025 09:06
@nix-owners nix-owners bot requested a review from eamsden October 8, 2025 09:49
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449829
Commit: 4913d1c002c42df90ee35bdf4a0611a60cf5c326

x86_64-linux

✅ 6 packages built:
  • ledger
  • ledger-autosync
  • ledger-autosync.dist
  • ledger.dev
  • python312Packages.ledger (python312Packages.ledger.dev, python312Packages.ledger.py)
  • python313Packages.ledger (python313Packages.ledger.dev, python313Packages.ledger.py)

aarch64-linux

✅ 6 packages built:
  • ledger
  • ledger-autosync
  • ledger-autosync.dist
  • ledger.dev
  • python312Packages.ledger (python312Packages.ledger.dev, python312Packages.ledger.py)
  • python313Packages.ledger (python313Packages.ledger.dev, python313Packages.ledger.py)

x86_64-darwin

✅ 6 packages built:
  • ledger
  • ledger-autosync
  • ledger-autosync.dist
  • ledger.dev
  • python312Packages.ledger (python312Packages.ledger.dev, python312Packages.ledger.py)
  • python313Packages.ledger (python313Packages.ledger.dev, python313Packages.ledger.py)

aarch64-darwin

✅ 6 packages built:
  • ledger
  • ledger-autosync
  • ledger-autosync.dist
  • ledger.dev
  • python312Packages.ledger (python312Packages.ledger.dev, python312Packages.ledger.py)
  • python313Packages.ledger (python313Packages.ledger.dev, python313Packages.ledger.py)

@GaetanLepage GaetanLepage requested review from kirillrdy and removed request for eamsden October 8, 2025 10:08
@kirillrdy kirillrdy added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 4c60fbd Oct 8, 2025
32 of 36 checks passed
@SchweGELBin SchweGELBin mentioned this pull request Oct 8, 2025
Closed
13 tasks
@GaetanLepage GaetanLepage deleted the ledger branch October 8, 2025 12:12
@SchweGELBin SchweGELBin mentioned this pull request Oct 8, 2025
Open
@panchoh
Copy link
Contributor

panchoh commented Oct 9, 2025

Bonjour, @GaetanLepage !

Thanks for the fix!

Please be aware of the recommendations offered in #445447 (especially point 3 at the top, further explained in @LordGrimmauld’s comment), and update accordingly if applicable.

@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Oct 9, 2025

Bonjour, @GaetanLepage !

Thanks for the fix!

Please be aware of the recommendations offered in #445447 (especially point 3 at the top, further explained in @LordGrimmauld’s comment), and update accordingly if applicable.

Thanks! For now, there has not been any fetchable patch upstream.

I updated the tracking issue, marking ledger as fixed.

nixvim-ci bot pushed a commit to nix-community/nixvim that referenced this pull request Oct 9, 2025
@GaetanLepage @nixvim-ci
tests/dependencies: disable ledger (build failure)
4d719d2 
Fixed in NixOS/nixpkgs#449829
nixvim-ci bot pushed a commit to nix-community/nixvim that referenced this pull request Oct 9, 2025
@GaetanLepage @nixvim-ci
tests/dependencies: disable ledger (build failure)
9bf6a58 
Fixed in NixOS/nixpkgs#449829
nixvim-ci bot pushed a commit to nix-community/nixvim that referenced this pull request Oct 9, 2025
@GaetanLepage @nixvim-ci
tests/dependencies: disable ledger (build failure)
8f678c2 
Fixed in NixOS/nixpkgs#449829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirillrdy kirillrdy kirillrdy approved these changes

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @panchoh @kirillrdy