Skip to content

ddate: fix build issue with CMake 4#449775

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
panchoh:fix/ddate-cmake-build
Oct 8, 2025
Merged

ddate: fix build issue with CMake 4#449775
Sigmanificient merged 1 commit intoNixOS:masterfrom
panchoh:fix/ddate-cmake-build

Conversation

@panchoh
Copy link
Contributor

@panchoh panchoh commented Oct 8, 2025

See #445447.

Thanks to @ppisar for providing the patch upstream!

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from KoviRobi October 8, 2025 05:40
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
Copy link
Contributor

@KoviRobi KoviRobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the patch is very trivial too

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 8, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449775
Commit: 97c7f569a5b45efd5a94cab7635d22e7ae5887d5 (subsequent changes)
Merge: 327e7176e9da81694e19453ea2d3cd62a3070948

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18339392388


x86_64-linux

✅ 1 package built:
  • ddate

aarch64-linux

✅ 1 package built:
  • ddate

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • ddate

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • ddate

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 2c12217 Oct 8, 2025
34 of 38 checks passed
@panchoh panchoh deleted the fix/ddate-cmake-build branch October 8, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants