nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449772
Commit: 0fba953a3017d6a3f48781df837c81849c3d3536

x86_64-linux

One of my machines ran into the failed build last night, but I would prefer a different approach to fixing:

• Add (lib.cmakeFeature "CMAKE_POLICY_VERSION_MINIMUM" "3.10") to cmakeFlags to fix this build.
• Add a new package raspi-utils, using the new version/repo, since that is what raspbian and the rest of the debian family calls the package.
• Remove libraspberrypi and reference the new package in the throw.

We could even match debian even more and have subpackages, but I doubt that's super useful:

$ sudo apt show raspi-utils
Package: raspi-utils
Version: 20251002-1
[...]
Depends: raspi-utils-core, raspi-utils-otp, raspi-utils-dt, raspi-utils-eeprom, raspinfo (>= 20240402-4)
[...]
Description: Collection of scripts and simple applications
 This is a meta-package that installs all of utilities

In retrospect, that is indeed a better solution.
This also softens any potential feature parity mismatch.

I'll rework this pull to just add the cmake flag and add a new package in time for 25.11, then maybe the removal/throw should be after.

And while the subpackages could be cool, I personally don't see much use

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449772
Commit: 6702d4e81d483d997d55868f754552166f521858

x86_64-linux

The second force push was me forgetting to update the commit message.

Commit content is identical for the purpose of the last nixpkgs-review

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449772
Commit: fe9c50a981240746b37b1d2966b4c06576278ee0

x86_64-linux

aarch64-linux

For tracking: This update resolve cmake4 update #445447

I have no opinion on which solution is better.

But we definitely need to merge one of these to resolve the build failure

I totally agree. Both of these fix an existing issue.
I'll leave it up to the maintainers. Just wanted to make you aware of the other pr.

Didn't notice you also were working on fixing the cmake4 issue
We prefer to use patches (or substituteInPlace) instead of cmake flags, for ease of futur debugging #445447 (comment)

But since the original repo got archived, there's an argument for the cmake flag, so let's leave it up to maintainers

We prefer to use patches (or substituteInPlace) instead of cmake flags, for ease of futur debugging #445447 (comment)

Thanks for that link. It explains the preference well and I had completely missed it.

Ofc, like you said, in this very specific case it kinda makes no difference.

I hope to deprecate libraspberrypi anyway #449925
I did just jump in at the deep end though, it's definitely beyond my usual work in nixpkgs

If anyone else can do some testing or help in other ways with #449925 it would be greatly appreciated!