hadoop: fix build with cmake 4#449767
Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom Oct 25, 2025
Merged
Conversation
13 tasks
samestep
approved these changes
Oct 24, 2025
Contributor
samestep
left a comment
There was a problem hiding this comment.
This successfully builds for me on x86_64-linux; is there a particular reason this PR is still marked as draft?
ac1f2ad to
6bb8c59
Compare
Contributor
Author
|
hadoop 2 was broken. The change I pushed just now should fix both hadoop 2 and 3. |
6bb8c59 to
4244b2e
Compare
samestep
approved these changes
Oct 25, 2025
Contributor
samestep
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 449767
Commit: 4244b2e4eeaff50b145c489760838299bdb7039b
x86_64-linux
✅ 14 packages built:
- hadoop (hadoop3, hadoop_3_4)
- hadoop2
- hadoop_3_3
- pig
- python312Packages.dask-yarn
- python312Packages.dask-yarn.dist
- python312Packages.skein
- python312Packages.skein.dist
- python313Packages.dask-yarn
- python313Packages.dask-yarn.dist
- python313Packages.skein
- python313Packages.skein.dist
- spark (spark3, spark_3_5)
- spark_3_4
Contributor
Author
|
I've tested |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sigmanificient
approved these changes
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#445447
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.