Skip to content

hadoop: fix build with cmake 4#449767

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
illustris:hadoop-ce-fix
Oct 25, 2025
Merged

hadoop: fix build with cmake 4#449767
Sigmanificient merged 1 commit intoNixOS:masterfrom
illustris:hadoop-ce-fix

Conversation

@illustris
Copy link
Contributor

@illustris illustris commented Oct 8, 2025

#445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 8, 2025
Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This successfully builds for me on x86_64-linux; is there a particular reason this PR is still marked as draft?

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 24, 2025
@illustris
Copy link
Contributor Author

hadoop 2 was broken. The change I pushed just now should fix both hadoop 2 and 3.

Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449767
Commit: 4244b2e4eeaff50b145c489760838299bdb7039b


x86_64-linux

✅ 14 packages built:
  • hadoop (hadoop3, hadoop_3_4)
  • hadoop2
  • hadoop_3_3
  • pig
  • python312Packages.dask-yarn
  • python312Packages.dask-yarn.dist
  • python312Packages.skein
  • python312Packages.skein.dist
  • python313Packages.dask-yarn
  • python313Packages.dask-yarn.dist
  • python313Packages.skein
  • python313Packages.skein.dist
  • spark (spark3, spark_3_5)
  • spark_3_4

@illustris illustris marked this pull request as ready for review October 25, 2025 17:33
@illustris
Copy link
Contributor Author

I've tested nixosTests.hadoop.all and nixosTests.hadoop2.all locally on x86_64-linux.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2611

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit f8c07a0 Oct 25, 2025
28 of 32 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants