Skip to content

openxcom: fix build with cmake 4#449757

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
keenanweaver:openxcom-fix
Oct 8, 2025
Merged

openxcom: fix build with cmake 4#449757
Sigmanificient merged 1 commit intoNixOS:masterfrom
keenanweaver:openxcom-fix

Conversation

@keenanweaver
Copy link
Member

#445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: games Gaming on NixOS labels Oct 8, 2025
@keenanweaver
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449757
Commit: 89fd38cc4968e16c50928bdf082c0b7d7a144385 (subsequent changes)
Merge: 8f0f59fd1f75ced8084f28095570e4bfa38afb9c

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/18331954885


x86_64-linux

✅ 1 package built:
  • openxcom

aarch64-linux

✅ 1 package built:
  • openxcom

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 8, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit a6fece3 Oct 8, 2025
32 of 36 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 8, 2025
@keenanweaver keenanweaver deleted the openxcom-fix branch October 13, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants