Skip to content

collada-dom: fix build against CMake >= 3.10#449740

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
SchweGELBin:collada-dom-fix
Oct 8, 2025
Merged

collada-dom: fix build against CMake >= 3.10#449740
SigmaSquadron merged 1 commit intoNixOS:masterfrom
SchweGELBin:collada-dom-fix

Conversation

@SchweGELBin
Copy link
Member

@SchweGELBin SchweGELBin commented Oct 8, 2025

See #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 8, 2025
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Oct 8, 2025 •
edited
Loading

Since upstream is controlled by @nim65s, we can probably fix this in the CMake list itself.

@SchweGELBin
Copy link
Member Author

SchweGELBin commented Oct 8, 2025

Since upstream is controlled by @nim65s, we can probably fix this in the CMake list itself.

I don't have anything against this.
If he updates the list and pushes a new tag, I can update the package here.
Just ping me and I'll do it.

Until then, this pr is still useful and can be reverted at the next package update.

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Oct 8, 2025

Until then, this pr is still useful and can be reverted at the next package update.

Yes, I'm running a build and will merge if OpenMW compiles successfully.

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449740
Commit: e14188e181a307fb130b391c2d6cc3681ddb598a

x86_64-linux

❌ 3 packages failed to build:
  • openmw
  • portmod
  • portmod.dist
✅ 1 package built:
  • collada-dom

@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Oct 8, 2025

Looks like pkgs.ois needs the same fix.

SigmaSquadron
SigmaSquadron approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openscenegraph builds correctly, ois needs more work in #449741.

@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 8, 2025
Merged via the queue into NixOS:master with commit aa61fd0 Oct 8, 2025
31 of 35 checks passed
@nim65s
Copy link
Contributor

nim65s commented Oct 8, 2025

On it

@nim65s
Copy link
Contributor

nim65s commented Oct 8, 2025

Btw, I did not notice that, because the package I use with collada-dom is currently broken because of #437521
So if anybody feels like merging this that would help me to detect failures earlier 😅

@nim65s nim65s mentioned this pull request Oct 8, 2025
Merged
@nim65s
Copy link
Contributor

nim65s commented Oct 8, 2025

OK for #449818 :)

@SchweGELBin SchweGELBin deleted the collada-dom-fix branch October 8, 2025 10:49
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

@marius851000 marius851000 Awaiting requested review from marius851000

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SchweGELBin @SigmaSquadron @nim65s