acc: fix build with cmake 4#449710
Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom Oct 9, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
Author
|
keenanweaver
force-pushed
the
acc-cmake
branch
from
11a2045 to
19a3458
Compare
Member
Author
|
keenanweaver
force-pushed
the
acc-cmake
branch
from
19a3458 to
f97e0e3
Compare
SigmaSquadron
approved these changes
Oct 9, 2025
Contributor
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
Apologies for the nagging reviews; looks good to me!
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
Contributor
|
oh, TIL nixpkgs-review bypasses the merge queue. |
panchoh
reviewed
Oct 9, 2025
| ./disable-static.patch | ||
| (fetchpatch { | ||
| name = "cmake-fix-1"; | ||
| url = "https://github.com/ZDoom/acc/commit/a0e7d2437c7f66a2b973537c2e854e2b91cd9c4c.patch"; |
Contributor
There was a problem hiding this comment.
Suggested change
| url = "https://github.com/ZDoom/acc/commit/a0e7d2437c7f66a2b973537c2e854e2b91cd9c4c.patch"; | |
| url = "https://github.com/ZDoom/acc/commit/a0e7d2437c7f66a2b973537c2e854e2b91cd9c4c.patch?full_index=1"; |
As per point 2.1 of #445447:
Don't forget to add ?full_index=1 to github patch fetching.
panchoh
reviewed
Oct 9, 2025
| }) | ||
| (fetchpatch { | ||
| name = "cmake-fix-2"; | ||
| url = "https://github.com/ZDoom/acc/commit/df6a2735acccad9131ce73fa07506445cfe69ec2.patch"; |
Contributor
There was a problem hiding this comment.
Suggested change
| url = "https://github.com/ZDoom/acc/commit/df6a2735acccad9131ce73fa07506445cfe69ec2.patch"; | |
| url = "https://github.com/ZDoom/acc/commit/df6a2735acccad9131ce73fa07506445cfe69ec2.patch?full_index=1"; |
As per point 2.1 of #445447:
Don't forget to add ?full_index=1 to github patch fetching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#445447
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.