Skip to content

libtins: fix cmake 4 compatibility#449694

Merged
SigmaSquadron merged 2 commits intoNixOS:masterfrom
SchweGELBin:libtins-fix
Oct 8, 2025
Merged

libtins: fix cmake 4 compatibility#449694
SigmaSquadron merged 2 commits intoNixOS:masterfrom
SchweGELBin:libtins-fix

Conversation

@SchweGELBin
Copy link
Member

@SchweGELBin SchweGELBin commented Oct 7, 2025

Resolves #449688
See: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from fdns October 7, 2025 23:03
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449694
Commit: 0d78bd0706de4989a38633fce74e614e0c3097ca (subsequent changes)
Merge: 5383d50ba54a122d742eef6567e8c13b159fd4bb

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18341477347


x86_64-linux

❌ 4 packages failed to build:
  • mathematica
  • mathematica-cuda
  • mathematica-webdoc
  • mathematica-webdoc-cuda
✅ 6 packages built:
  • compactor
  • dublin-traceroute
  • dublin-traceroute.dev
  • dublin-traceroute.lib
  • libtins
  • open5gs

aarch64-linux

✅ 6 packages built:
  • compactor
  • dublin-traceroute
  • dublin-traceroute.dev
  • dublin-traceroute.lib
  • libtins
  • open5gs

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • compactor
  • libtins
  • open5gs

aarch64-darwin (sandbox = true)

✅ 3 packages built:
  • compactor
  • libtins
  • open5gs

@SchweGELBin
Copy link
Member Author

Hello, I've bumped the minimum version from 3.5 to 3.10 as suggested in the tracking issue.

@SchweGELBin SchweGELBin changed the title libtins: fix build against CMake >= 3.5 libtins: fix cmake 4 compatibility Oct 8, 2025
@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit ef8cf06 Oct 8, 2025
27 checks passed
@SchweGELBin SchweGELBin deleted the libtins-fix branch October 8, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: libtins

3 participants