Skip to content

pulseview: 0.4.2-unstable-2024-03-14 -> 0.5.0-unstable-2025-05-15#449652

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
maxmosk:nixos-unstable-pulseview
Oct 8, 2025
Merged

pulseview: 0.4.2-unstable-2024-03-14 -> 0.5.0-unstable-2025-05-15#449652
bjornfor merged 1 commit intoNixOS:masterfrom
maxmosk:nixos-unstable-pulseview

Conversation

@maxmosk
Copy link
Contributor

@maxmosk maxmosk commented Oct 7, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Oct 7, 2025
@nix-owners nix-owners bot requested review from bjornfor and vifino October 7, 2025 21:12
@vifino
Copy link
Member

vifino commented Oct 7, 2025

Hi! Bumping pulseview sounds good to me, but could you check and bump the sigrok derivations as well if there have been changes?
Thanks!

@maxmosk
Copy link
Contributor Author

maxmosk commented Oct 7, 2025

Hi! Bumping pulseview sounds good to me, but could you check and bump the sigrok derivations as well if there have been changes? Thanks!

Can i do it in next PRs? Sigrok isn't in active development, that's why looks like still compatible.

vifino
vifino suggested changes Oct 8, 2025
View reviewed changes
Copy link
Member

@vifino vifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes between commits: sigrokproject/pulseview@d00efc6...master

pkgs/applications/science/electronics/pulseview/default.nix Outdated
@@ -24,12 +24,13 @@

stdenv.mkDerivation {
pname = "pulseview";
version = "0.4.2-unstable-2024-03-14";
version = "0.5.0-unstable-2025-05-15";
Copy link
Member

@vifino vifino Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the version back to 0.4.2. See also: https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#versioning

Copy link
Contributor Author

@maxmosk maxmosk Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but why? Looks like right version is 0-unstable-2025-05-15 due to no release tag or branch.
btw pulseview --version prints 0.5.0

Copy link
Member

@vifino vifino Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were stable releases for pulseview, the latest one is 0.4.2 (see sigrok Downloads) even if they aren't tagged in git.
Policy is to use the previous stable version as base.

Copy link
Contributor Author

@maxmosk maxmosk Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@maxmosk maxmosk force-pushed the nixos-unstable-pulseview branch from dafe4cb to 5e05cff Compare October 8, 2025 09:05
@vifino vifino mentioned this pull request Oct 8, 2025
Closed
13 tasks
vifino
vifino approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@vifino vifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449652
Commit: 5e05cffceb31922c0071df3f1a5069efa8e79875

x86_64-linux

✅ 1 package built:
  • pulseview

@maxmosk maxmosk force-pushed the nixos-unstable-pulseview branch from 5e05cff to 6a45361 Compare October 8, 2025 09:42
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 8, 2025
@yayayayaka yayayayaka mentioned this pull request Oct 8, 2025
Open
@maxmosk
Copy link
Contributor Author

maxmosk commented Oct 8, 2025

How to request review and merge? What should do next?

bjornfor
bjornfor approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is a reason to update to an unstable version in nixpkgs, we really should ping upstream to make a release. (But OK, I'll merge this one.)

@bjornfor bjornfor added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 529413c Oct 8, 2025
25 of 29 checks passed
@maxmosk
Copy link
Contributor Author

maxmosk commented Oct 18, 2025

If there is a reason to update to an unstable version in nixpkgs, we really should ping upstream to make a release. (But OK, I'll merge this one.)

Upstream looks not alive :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

+1 more reviewer

@vifino vifino vifino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxmosk @vifino @bjornfor