Skip to content

spectre-cli: Fix CMake 4 build issue#449631

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
Masrepus:patch-1
Oct 8, 2025
Merged

spectre-cli: Fix CMake 4 build issue#449631
SigmaSquadron merged 1 commit intoNixOS:masterfrom
Masrepus:patch-1

Conversation

@Masrepus
Copy link
Contributor

@Masrepus Masrepus commented Oct 7, 2025 •
edited by Sigmanificient
Loading

Since CMake 4 dropped support for CMake <3.5, spectre-cli doesn't currently build because it expects a minimum version of 3.0.7.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Masrepus Masrepus changed the title Make spectre-cli work with CMake 4 spectre-cli: Fix CMake 4 build issue Oct 7, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from emmabastas October 7, 2025 20:15
@yayayayaka yayayayaka mentioned this pull request Oct 8, 2025
Open
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449631
Commit: 4c3e67f112be7a2264576fb3dad45c6d44f811ff (subsequent changes)
Merge: 9e01d214c3e9d40c47e6242c1b469a0480941188

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18341481249

x86_64-linux

✅ 1 package built:
  • spectre-cli

aarch64-linux

✅ 1 package built:
  • spectre-cli

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • spectre-cli

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • spectre-cli

SigmaSquadron
SigmaSquadron approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for helping mitigate the CMake fallout, and welcome to Nixpkgs!

@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 6c97846 Oct 8, 2025
34 checks passed
@Masrepus
Copy link
Contributor Author

Masrepus commented Oct 8, 2025

Thanks for handling this PR so quickly and for the warm welcome!

I have a question regarding the general process, for the future: Would I as the PR author usually run nixpkgs-review and let it post the result, or is that something the "actual" reviewer would do, like @Sigmanificient did it here? Reading through the issue template checklist, it sounds a bit like I could/should have done it already from the start 🤔

@Masrepus Masrepus deleted the patch-1 branch October 8, 2025 13:37
@SigmaSquadron
Copy link
Contributor

SigmaSquadron commented Oct 8, 2025

Ideally it's both the PR author and the reviewers that run it. It costs basically nothing to run it (other than a few CPU cycles), so posting a PR and then running nixpkgs-review on it immediately after the CI is done is a good idea.

@Masrepus
Copy link
Contributor Author

Masrepus commented Oct 9, 2025

Alright, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SigmaSquadron SigmaSquadron SigmaSquadron approved these changes

@emmabastas emmabastas Awaiting requested review from emmabastas

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Masrepus @Sigmanificient @SigmaSquadron