cmark-gfm: fix cmake 4 build errors#449569
Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom Oct 7, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
LordGrimmauld
approved these changes
Oct 7, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
Built successfully on x86-64.
cmark-gfm looks inactive upstream, so probably little chance of landing an upstream fix. cmark has diverged a lot and also only does cmake min version 3.7, which is not enough.
Therefore, a substitute is reasonable. LGTM.
Contributor
|
(Nit: 3.10 should be enough to fix these cmake issues, 3.13 is technically higher than it needs to be. But if it doesn't cause issues, i don't care too much.) |
cyplo
approved these changes
Oct 7, 2025
Member
|
nixpkgs-ci
bot
added
12.approvals: 2
This was referenced Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #445447 for cmark-gfm
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.