Skip to content

ltrace: fix test failure with PIE#449551

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
LunNova:push-nwskmlwxlxlq
Oct 9, 2025
Merged

ltrace: fix test failure with PIE#449551
jtojnar merged 1 commit intoNixOS:masterfrom
LunNova:push-nwskmlwxlxlq

Conversation

@LunNova
Copy link
Member

@LunNova LunNova commented Oct 7, 2025 •
edited
Loading

Fixes #439314

Bisect says this change broke ltrace testsuite in master:

$ nix build --no-link -f. -L ltrace
...
ltrace> Running /build/ltrace-0.7.91/testsuite/ltrace.minor/print-instruction-pointer.exp ...
ltrace> FAIL: 1161.*printf in /build/ltrace-0.7.91/testsuite/ltrace.minor/print-instruction-pointer.ltrace for 0 times, should be 1
ltrace> FAIL: 1181.*printf in /build/ltrace-0.7.91/testsuite/ltrace.minor/print-instruction-pointer.ltrace for 0 times, should be 1
ltrace>                 ===  Summary ===
ltrace>
ltrace> # of expected passes            242
ltrace> # of unexpected failures        2
ltrace> # of unsupported tests          1
ltrace> make[4]: *** [Makefile:498: check-DEJAGNU] Error 1

Originally posted by @trofi in #439314 (comment)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 7, 2025
@trofi
Copy link
Contributor

trofi commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449551
Commit: 34f4cec222e7d045e28f814975444e1bb1e1c43a

x86_64-linux

✅ 2 packages built:
  • ltrace
  • nixpkgs-manual

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 8, 2025
mjoerg
mjoerg reviewed Oct 9, 2025
View reviewed changes
@LunNova LunNova requested a review from mjoerg October 9, 2025 15:30
@LunNova LunNova force-pushed the push-nwskmlwxlxlq branch 2 times, most recently from 7a2eaed to 892e94b Compare October 9, 2025 15:37
mjoerg
mjoerg approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@mjoerg mjoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449551
Commit: f9627d40ad5f31222c0659d9beafdbcced63345f

x86_64-linux

✅ 1 package built:
  • ltrace

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 9, 2025
@jtojnar jtojnar added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit d9b0ada Oct 9, 2025
28 of 32 checks passed
@LunNova LunNova deleted the push-nwskmlwxlxlq branch October 9, 2025 19:36
@typedrat typedrat mentioned this pull request Oct 10, 2025
Closed
3 tasks
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@Bad3r Bad3r mentioned this pull request Jan 2, 2026
Open
Bad3r added a commit to Bad3r/nixos that referenced this pull request Jan 2, 2026
@Bad3r
fix(ltrace): disable ltrace due to PIE test failure in nixpkgs-unstable
0b27ebb 
ltrace-0.7.91 fails to build in current nixpkgs-unstable due to
trace-clone test failures. The fix (PR #449551) was merged to master
but hasn't propagated to nixpkgs-unstable yet.

Refs #42

See: NixOS/nixpkgs#449551
Bad3r added a commit to Bad3r/nixos that referenced this pull request Jan 23, 2026
@Bad3r
fix(ltrace): disable ltrace due to PIE test failure in nixpkgs-unstable
87e6a44 
ltrace-0.7.91 fails to build in current nixpkgs-unstable due to
trace-clone test failures. The fix (PR #449551) was merged to master
but hasn't propagated to nixpkgs-unstable yet.

Refs #42

See: NixOS/nixpkgs#449551
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

3 more reviewers

@mjoerg mjoerg mjoerg approved these changes

@trofi trofi trofi approved these changes

@sliedes sliedes sliedes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LunNova @trofi @mjoerg @sliedes @jtojnar