Skip to content

tinyobjloader: fix build with cmake 4#449505

Merged
SigmaSquadron merged 1 commit intoNixOS:masterfrom
wrvsrx:fix-tinyobjloader
Oct 8, 2025
Merged

tinyobjloader: fix build with cmake 4#449505
SigmaSquadron merged 1 commit intoNixOS:masterfrom
wrvsrx:fix-tinyobjloader

Conversation

@wrvsrx
Copy link
Contributor

@wrvsrx wrvsrx commented Oct 7, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 7, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449505
Commit: 1c7cbe4f5b14aa59940327f54f54ed3091587868 (subsequent changes)
Merge: a7a89a489779f64b777e24f023f473129a937c56

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18323143919


x86_64-linux

✅ 1 package built:
  • tinyobjloader

aarch64-linux

✅ 1 package built:
  • tinyobjloader

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • tinyobjloader

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • tinyobjloader

@SigmaSquadron SigmaSquadron added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 77dd482 Oct 8, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants