Skip to content

highfive: fix build with cmake 4#449504

Merged
markuskowa merged 1 commit intoNixOS:masterfrom
wrvsrx:fix-highfive
Oct 8, 2025
Merged

highfive: fix build with cmake 4#449504
markuskowa merged 1 commit intoNixOS:masterfrom
wrvsrx:fix-highfive

Conversation

@wrvsrx
Copy link
Contributor

@wrvsrx wrvsrx commented Oct 7, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from robertodr October 7, 2025 13:35
@matteo-pacini
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449504
Commit: 33e400d14eba1acb5513ea14b1aedb79454a799d (subsequent changes)
Merge: d6f3814c3ad76e2d730a3e6cd62e45001330caa6

Logs: https://github.com/matteo-pacini/nixpkgs-review-gha/actions/runs/18320367920


x86_64-linux

❌ 4 packages failed to build:
  • herwig
  • python312Packages.rivet
  • rivet (python313Packages.rivet)
  • thepeg
✅ 2 packages built:
  • highfive
  • highfive-mpi

aarch64-linux

❌ 3 packages failed to build:
  • python312Packages.rivet
  • rivet (python313Packages.rivet)
  • thepeg
✅ 2 packages built:
  • highfive
  • highfive-mpi

x86_64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python312Packages.rivet
  • rivet (python313Packages.rivet)
✅ 2 packages built:
  • highfive
  • highfive-mpi

aarch64-darwin (sandbox = true)

❌ 2 packages failed to build:
  • python312Packages.rivet
  • rivet (python313Packages.rivet)
✅ 2 packages built:
  • highfive
  • highfive-mpi

@markuskowa
Copy link
Member

Dependent failures are partly due to davix (cmake4 failure).

@markuskowa markuskowa added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit 98ecda1 Oct 8, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants