Skip to content

halibut: Fix build with cmake4#449469

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
jshholland:fix-halibut-cmake4
Oct 7, 2025
Merged

halibut: Fix build with cmake4#449469
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
jshholland:fix-halibut-cmake4

Conversation

@jshholland
Copy link
Contributor

@jshholland jshholland commented Oct 7, 2025

The only CMakeLists.txt file that needs patching in the released 1.3 version is the one under charset/. The top-level one specifies compatibility up to CMake 3.5, but there is an unreleased commit updating the spec to 3.7...3.28.

Related: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from pSub October 7, 2025 11:15
@JohnRTitor
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449469

Logs: https://github.com/JohnRTitor/nixpkgs-review-gha/actions/runs/18313090612


x86_64-linux

✅ 7 packages built:
  • agedu
  • halibut
  • sgt-puzzles
  • sgt-puzzles-mobile
  • spigot
  • spigot.man
  • xtruss

aarch64-linux

✅ 7 packages built:
  • agedu
  • halibut
  • sgt-puzzles
  • sgt-puzzles-mobile
  • spigot
  • spigot.man
  • xtruss

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • agedu
  • halibut
  • spigot
  • spigot.man
  • xtruss

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • agedu
  • halibut
  • spigot
  • spigot.man
  • xtruss

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 7, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 7, 2025
Merged via the queue into NixOS:master with commit 3ccc63d Oct 7, 2025
31 of 35 checks passed
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449469
Commit: 9833723db2cdca89cbf96e7106ce75a6fbdbb3e7 (subsequent changes)
Merge: d985fdd90e7f1c2ce5672762962a7c5fe8f0da4c

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18313162192


x86_64-linux

✅ 7 packages built:
  • agedu
  • halibut
  • sgt-puzzles
  • sgt-puzzles-mobile
  • spigot
  • spigot.man
  • xtruss

aarch64-linux

✅ 7 packages built:
  • agedu
  • halibut
  • sgt-puzzles
  • sgt-puzzles-mobile
  • spigot
  • spigot.man
  • xtruss

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • agedu
  • halibut
  • spigot
  • spigot.man
  • xtruss

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • agedu
  • halibut
  • spigot
  • spigot.man
  • xtruss

@jshholland jshholland deleted the fix-halibut-cmake4 branch October 7, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants