Skip to content

imhex: fix build with cmake 4#449412

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
ryand56:imhex/cmake4
Oct 7, 2025
Merged

imhex: fix build with cmake 4#449412
Sigmanificient merged 2 commits intoNixOS:masterfrom
ryand56:imhex/cmake4

Conversation

@ryand56
Copy link
Member

@ryand56 ryand56 commented Oct 7, 2025 •
edited
Loading

Related: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ryand56 ryand56 marked this pull request as draft October 7, 2025 08:28
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 7, 2025
@nix-owners nix-owners bot requested review from GovanifY, cafkafk and kashw2 October 7, 2025 08:33
@ryand56 ryand56 marked this pull request as ready for review October 7, 2025 08:40
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449412
Commit: c5a28a89cd7771dbde4d55edbc64536c907a05e1 (subsequent changes)
Merge: 99544ca6e86373d7d8d0463a5248b488a28aaf19

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18307615175

x86_64-linux

✅ 1 package built:
  • imhex

aarch64-linux

✅ 1 package built:
  • imhex

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • imhex

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • imhex

@ryand56 ryand56 mentioned this pull request Oct 7, 2025
Closed
3 tasks
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 511ed04 Oct 7, 2025
27 of 31 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 7, 2025
@ryand56 ryand56 deleted the imhex/cmake4 branch October 7, 2025 15:33
@LordGrimmauld LordGrimmauld mentioned this pull request Oct 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@kashw2 kashw2 Awaiting requested review from kashw2

@GovanifY GovanifY Awaiting requested review from GovanifY

@cafkafk cafkafk Awaiting requested review from cafkafk

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryand56 @Sigmanificient