Skip to content

libvdpau-va-gl: fix build with cmake4#449409

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
wrvsrx:fix-libvdpau-va-gl
Oct 7, 2025
Merged

libvdpau-va-gl: fix build with cmake4#449409
Sigmanificient merged 1 commit intoNixOS:masterfrom
wrvsrx:fix-libvdpau-va-gl

Conversation

@wrvsrx
Copy link
Contributor

@wrvsrx wrvsrx commented Oct 7, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@teto
Copy link
Member

teto commented Oct 7, 2025

other attempt at #449230 but this one looks more sensible

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 7, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 7, 2025
@teto
Copy link
Member

teto commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449409
Commit: 1aaad1adbe24fafeeb30b50070ff9e239314ba2b

x86_64-linux

✅ 2 packages built:
  • driversi686Linux.libvdpau-va-gl
  • libvdpau-va-gl

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 7, 2025
@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 249d008 Oct 7, 2025
31 of 35 checks passed
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449409
Commit: 1aaad1adbe24fafeeb30b50070ff9e239314ba2b (subsequent changes)
Merge: 6336ea2e82acfaaea0b1356944455fae6172d312

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18309647709

x86_64-linux

✅ 2 packages built:
  • driversi686Linux.libvdpau-va-gl
  • libvdpau-va-gl

aarch64-linux

✅ 1 package built:
  • libvdpau-va-gl

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@teto
Copy link
Member

teto commented Oct 7, 2025

reading the chat, there seems to be a fix in staging #444579 . Mentioning it just when it creates an issue.

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Oct 7, 2025

Uhm... This is not the way.

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Oct 7, 2025

We should prefer patches over CLI flags, because patches will fail once upstream adjusts their cmake. CLI flags will be forgotten and cause breakages down the line.
And trofis PR should have beem merged to master (well, staging-next at the time), i intended to fix that.

@LordGrimmauld LordGrimmauld mentioned this pull request Oct 7, 2025
Merged
13 tasks
@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Oct 7, 2025

Revert and pick of trofis PR to master in #449482

@wrvsrx wrvsrx deleted the fix-libvdpau-va-gl branch October 8, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teto teto teto approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wrvsrx @teto @Sigmanificient @LordGrimmauld