Skip to content

dislocker: fix build against CMake >= 4.0#449377

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
mjoerg:dislocker-fix-cmake-4
Oct 9, 2025
Merged

dislocker: fix build against CMake >= 4.0#449377
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
mjoerg:dislocker-fix-cmake-4

Conversation

@mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: 4ed1f23de3dea1e44d2c39cae3bd1b942c0b6821


x86_64-linux

✅ 1 package built:
  • dislocker

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from elitak October 7, 2025 06:48
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449377
Commit: 4ed1f23de3dea1e44d2c39cae3bd1b942c0b6821 (subsequent changes)
Merge: df4f4949fcf7ae83d1ba3858938c702b45486bf2

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18307626640


x86_64-linux

✅ 1 package built:
  • dislocker

aarch64-linux

✅ 1 package built:
  • dislocker

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • dislocker

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • dislocker

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit e5943ac Oct 9, 2025
34 of 36 checks passed
@yuannan
Copy link
Member

yuannan commented Oct 10, 2025

Why are we using 0.7.3? This hasn't been updated since 2020.

Can we not point at the lastest commit?

@SuperSandro2000
Copy link
Member

That's the latest release. If someone wants to, we could update it to an unstable version.

@yuannan
Copy link
Member

yuannan commented Oct 10, 2025

That's the latest release. If someone wants to, we could update it to an unstable version.

Please, there are a LOT of commits since, then. 0.7.3 was in 2020, it doesn't work well with some newer stuff. Do you want to open the PR, or should I?

@SuperSandro2000
Copy link
Member

I am not using the software at all, so it is best if you do it and also can test if basic things are still working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants