Skip to content

superTuxKart: fix build against cmake 4#449358

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
uninsane:pr-supertuxkart-cmake4
Oct 10, 2025
Merged

superTuxKart: fix build against cmake 4#449358
LordGrimmauld merged 1 commit intoNixOS:masterfrom
uninsane:pr-supertuxkart-cmake4

Conversation

@uninsane
Copy link
Contributor

@uninsane uninsane commented Oct 7, 2025

this plus #449352 fix the superTuxKart build on master; can be merged in either order.

cmake4 tracking issue: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from peterhoeg October 7, 2025 05:18
@uninsane uninsane force-pushed the pr-supertuxkart-cmake4 branch from 652fcc7 to 4b51066 Compare October 7, 2025 09:48
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449358
Commit: 652fcc7a230ebef774a1fb85d029d93a4f2677a2 (subsequent changes)
Merge: 23b9e44c28111f15c5195371bcca006bda50dcb6

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18307627923


x86_64-linux

❌ 1 package failed to build:
  • superTuxKart

aarch64-linux

❌ 1 package failed to build:
  • superTuxKart

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • superTuxKart

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • superTuxKart

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depends on #449352, but picking both of these to a shared branch, the build does indeed succeed.
image

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 7, 2025
@uninsane uninsane force-pushed the pr-supertuxkart-cmake4 branch from 4b51066 to 1cfa813 Compare October 10, 2025 09:18
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work when rebased to current master

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit eedd51a Oct 10, 2025
27 of 31 checks passed
nim65s added a commit to nim65s/dotfiles that referenced this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants