Skip to content

libopenglrecorder: fix build against cmake 4#449352

Closed
uninsane wants to merge 1 commit intoNixOS:masterfrom
uninsane:pr-libopenglrecorder-cmake4
Closed

libopenglrecorder: fix build against cmake 4#449352
uninsane wants to merge 1 commit intoNixOS:masterfrom
uninsane:pr-libopenglrecorder-cmake4

Conversation

@uninsane
Copy link
Contributor

@uninsane uninsane commented Oct 7, 2025

cmake4 tracking issue: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from OPNA2608 October 7, 2025 04:20
@uninsane uninsane force-pushed the pr-libopenglrecorder-cmake4 branch from cbc3ce6 to 339e21c Compare October 10, 2025 08:59
@uninsane
Copy link
Contributor Author

should be fixed. the patch was merged upstream, so the fetchpatch is referencing an actual commit that lives on master.

actually, we could just bump libopenglrecorder to the latest version: the only new commit is the commit we'd otherwise be cherry-picking. here's what that would look like: #449888

thanks for teaching about Github's commit gc'ing btw -- did not know they did that.

@uninsane uninsane closed this Oct 10, 2025
@LordGrimmauld
Copy link
Contributor

Thank you for tackling this, and for your patience with the reviews - even though this was not the approach that was ultimately merged ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants