Skip to content

animatch: fix build with cmake 4#449327

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
uninsane:pr-animatch-20251006
Oct 9, 2025
Merged

animatch: fix build with cmake 4#449327
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
uninsane:pr-animatch-20251006

Conversation

@uninsane
Copy link
Contributor

@uninsane uninsane commented Oct 7, 2025

tracking issue for cmake 4 build failures: #445447

building this requires #449324 but they can be merged in any order.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 7, 2025
@uninsane uninsane force-pushed the pr-animatch-20251006 branch from a266547 to f3868b2 Compare October 7, 2025 06:46
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449327
Commit: f3868b2591b1dc84cdbee62a676820fb1426302b (subsequent changes)
Merge: dc99b7e4d02086c58a96617d4881884553b1a2b3

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18307622453


x86_64-linux

❌ 1 package failed to build:
  • animatch

aarch64-linux

❌ 1 package failed to build:
  • animatch

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • animatch

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • animatch

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 7, 2025
@SuperSandroBot
Copy link

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449327
Commit: f3868b2591b1dc84cdbee62a676820fb1426302b (subsequent changes)
Merge: 32de5b338e79eb801ab683b536745c72c89ba6f0

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18376617963


x86_64-linux

✅ 1 package built:
  • animatch

aarch64-linux

✅ 1 package built:
  • animatch

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • animatch

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • animatch

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit 18432bd Oct 9, 2025
30 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants