Skip to content

allegro5: fix build with cmake 4#449324

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
uninsane:pr-allegro5
Oct 7, 2025
Merged

allegro5: fix build with cmake 4#449324
Sigmanificient merged 2 commits intoNixOS:masterfrom
uninsane:pr-allegro5

Conversation

@uninsane
Copy link
Contributor

@uninsane uninsane commented Oct 7, 2025 •
edited
Loading

tracking issue for cmake 4 build failures: #445447

also enabled strictDeps. diffed the package with and without it -- looks the same. i've been using pkgsCross.aarch64-multiplatform.allegro5 where strictDeps is implicitly set true, and that's been fine.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 7, 2025
@nix-owners nix-owners bot requested a review from 7c6f434c October 7, 2025 02:19
@uninsane uninsane mentioned this pull request Oct 7, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 7, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449324
Commit: ea012a52067fe9f3cb86e0378b98189c8d3f877d (subsequent changes)
Merge: e67cfb06142b360526d158317ce1f5ea2365646f

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18307617078

x86_64-linux

❌ 2 packages failed to build:
  • animatch
  • opensurge
✅ 5 packages built:
  • allegro5
  • allegro5.dev
  • dfhack (dwarf-fortress-full, dwarf-fortress-packages.dwarf-fortress-full)
  • liberation-circuit
  • sbclPackages.cl-liballegro-nuklear
Error logs: `x86_64-linux`
animatch 
CMake Deprecation Warning at libsuperderpy/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


CMake Error at libsuperderpy/src/3rdparty/cimgui/CMakeLists.txt:1 (cmake_minimum_required):

Compatibility with CMake < 3.5 has been removed from CMake.


Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-linux

❌ 2 packages failed to build:
  • animatch
  • opensurge
✅ 4 packages built:
  • allegro5
  • allegro5.dev
  • liberation-circuit
  • sbclPackages.cl-liballegro-nuklear
Error logs: `aarch64-linux`
animatch 
CMake Deprecation Warning at libsuperderpy/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


CMake Error at libsuperderpy/src/3rdparty/cimgui/CMakeLists.txt:1 (cmake_minimum_required):

Compatibility with CMake < 3.5 has been removed from CMake.


Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

x86_64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • animatch
  • opensurge
  • sbclPackages.cl-liballegro-nuklear
✅ 2 packages built:
  • allegro5
  • allegro5.dev
Error logs: `x86_64-darwin`
animatch 
CMake Deprecation Warning at libsuperderpy/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


CMake Error at libsuperderpy/src/3rdparty/cimgui/CMakeLists.txt:1 (cmake_minimum_required):

Compatibility with CMake < 3.5 has been removed from CMake.


Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-darwin (sandbox = true)

❌ 3 packages failed to build:
  • animatch
  • opensurge
  • sbclPackages.cl-liballegro-nuklear
✅ 2 packages built:
  • allegro5
  • allegro5.dev
Error logs: `aarch64-darwin`
animatch 
CMake Deprecation Warning at libsuperderpy/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


CMake Error at libsuperderpy/src/3rdparty/cimgui/CMakeLists.txt:1 (cmake_minimum_required):

Compatibility with CMake < 3.5 has been removed from CMake.


Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 5d28df9 Oct 7, 2025
27 of 31 checks passed
@LordGrimmauld LordGrimmauld mentioned this pull request Oct 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teto teto teto approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uninsane @Sigmanificient @teto