Skip to content

flare: backport upstream cmake-4 fixes#449265

Merged
azahi merged 1 commit intoNixOS:masterfrom
trofi:flare-cmake-4-fix
Oct 7, 2025
Merged

flare: backport upstream cmake-4 fixes#449265
azahi merged 1 commit intoNixOS:masterfrom
trofi:flare-cmake-4-fix

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 6, 2025

Without the change the build fails on` master as:

flare-game> CMake Error at /build/innoextract-1.9/cmake/VersionScript.cmake:20 (cmake_minimum_required):
flare-game>   Compatibility with CMake < 3.5 has been removed from CMake.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@trofi trofi mentioned this pull request Oct 6, 2025
13 tasks
Without the change the build fails on` master as:

    flare-game> CMake Error at /build/innoextract-1.9/cmake/VersionScript.cmake:20 (cmake_minimum_required):
    flare-game>   Compatibility with CMake < 3.5 has been removed from CMake.
@trofi trofi force-pushed the flare-cmake-4-fix branch from 3fb6fda to fadc49a Compare October 6, 2025 21:45
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 6, 2025
@trofi
Copy link
Contributor Author

trofi commented Oct 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449265
Commit: 3fb6fda62defa94cad84f4995e74b63e74c71737


x86_64-linux

✅ 2 packages built:
  • flare
  • nixpkgs-manual

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 6, 2025
@azahi azahi added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 7d391ac Oct 7, 2025
34 of 36 checks passed
@trofi trofi deleted the flare-cmake-4-fix branch October 7, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants