Skip to content

innoextract: 1.9 -> 1.9-unstable-2025-02-06 (cmake-4 compatible)#449252

Merged
azahi merged 1 commit intoNixOS:masterfrom
trofi:innoextract-fix-cmake-4-build
Oct 7, 2025
Merged

innoextract: 1.9 -> 1.9-unstable-2025-02-06 (cmake-4 compatible)#449252
azahi merged 1 commit intoNixOS:masterfrom
trofi:innoextract-fix-cmake-4-build

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 6, 2025 •
edited
Loading

Without the change the build fails on` master as:

innoextract> CMake Error at /build/innoextract-1.9/cmake/VersionScript.cmake:20 (cmake_minimum_required):
innoextract>   Compatibility with CMake < 3.5 has been removed from CMake.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@trofi
innoextract: 1.9 -> 1.9-unstable-2025-02-06 (cmake-4 compatible)
e37080a 
Without the change the build fails on` master as:

    innoextract> CMake Error at /build/innoextract-1.9/cmake/VersionScript.cmake:20 (cmake_minimum_required):
    innoextract>   Compatibility with CMake < 3.5 has been removed from CMake.
@trofi trofi mentioned this pull request Oct 6, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 6, 2025
@trofi
Copy link
Contributor Author

trofi commented Oct 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449252
Commit: e37080a4cc67bdd010517c2bd14c3cf10e90e5e8

x86_64-linux

❌ 6 packages failed to build:
  • d1x-rebirth-full
  • d2x-rebirth-full
  • descent1-assets
  • descent2-assets
  • openrct2
  • vcmi
✅ 4 packages built:
  • gogUnpackHook
  • innoextract
  • iscc
  • nixpkgs-manual

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 6, 2025
@matteo-pacini
Copy link
Contributor

matteo-pacini commented Oct 7, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449252
Commit: e37080a4cc67bdd010517c2bd14c3cf10e90e5e8 (subsequent changes)
Merge: b5b6acd1879c1f510fecbcdc16c706ea98923899

Logs: https://github.com/matteo-pacini/nixpkgs-review-gha/actions/runs/18307098819

x86_64-linux

❌ 2 packages failed to build:
  • openrct2
  • vcmi
✅ 3 packages built:
  • gogUnpackHook
  • innoextract
  • iscc

aarch64-linux

❌ 2 packages failed to build:
  • openrct2
  • vcmi
✅ 2 packages built:
  • gogUnpackHook
  • innoextract

x86_64-darwin (sandbox = true)

✅ 3 packages built:
  • gogUnpackHook
  • innoextract
  • iscc

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • gogUnpackHook
  • innoextract

@keenanweaver keenanweaver mentioned this pull request Oct 7, 2025
Merged
13 tasks
keenanweaver
keenanweaver approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openrct2 should be fixed with this change and the linked one above.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 7, 2025
@azahi azahi enabled auto-merge October 7, 2025 15:27
@azahi azahi added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 3c72d0d Oct 7, 2025
35 of 37 checks passed
@trofi trofi deleted the innoextract-fix-cmake-4-build branch October 7, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@keenanweaver keenanweaver keenanweaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trofi @matteo-pacini @keenanweaver @azahi