Skip to content

libunarr: backport cmake-4 incompatibility#449247

Merged
fabianhjr merged 1 commit intoNixOS:masterfrom
trofi:libunarr-cmake-4-fix
Oct 7, 2025
Merged

libunarr: backport cmake-4 incompatibility#449247
fabianhjr merged 1 commit intoNixOS:masterfrom
trofi:libunarr-cmake-4-fix

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 6, 2025 •
edited
Loading

Without the upstream fix the build fails as:

libunarr> CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
libunarr>   Compatibility with CMake < 3.5 has been removed from CMake.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@trofi
libunarr: backport cmake-4 incompatibility
bc5b354 
Without the upstream fix the build fails as:

    libunarr> CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
    libunarr>   Compatibility with CMake < 3.5 has been removed from CMake.
@trofi trofi mentioned this pull request Oct 6, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 6, 2025
@nix-owners nix-owners bot requested a review from wegank October 6, 2025 20:47
@trofi
Copy link
Contributor Author

trofi commented Oct 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449247
Commit: bc5b354ef0d3ac551c11450b125f66a381d04f4e

x86_64-linux

❌ 3 packages failed to build:
  • cbconvert
  • cbconvert-gui
  • opencpn
✅ 4 packages built:
  • libunarr
  • nanoboyadvance
  • nixpkgs-manual
  • yacreader
Error logs: `x86_64-linux`
cbconvert 
Using versionCheckHook
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/a0gph1qalvrfani4q9dmbjl8s2x1vlja-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
Building subPackage .
# github.com/gen2brain/go-fitz
vendor/github.com/gen2brain/go-fitz/fitz_cgo.go:543:103: cannot use _Ctype_int(len(buf)) (value of int32 type _Ctype_int) as _Ctype_size_t value in variable declaration
opencpn 
-- OpenSSL found /nix/store/cz9k6nhxjppa1kmyf5npd0g8l89xzilw-openssl-3.5.2-dev/include /nix/store/0837wpkjb27cr70bi3pc4g2rw5v9r63l-openssl-3.5.2/lib/libssl.so;/nix/store/0837wpkjb27cr70bi3pc4g2rw5v9r63l-openssl-3.5.2/lib/libcrypto.so
-- CMAKE_MODULE_PATH : /build/source/model/cmake
-- Looking for lzma_auto_decoder in /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so
-- Looking for lzma_auto_decoder in /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so - found
-- Looking for lzma_easy_encoder in /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so
-- Looking for lzma_easy_encoder in /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so - found
-- Looking for lzma_lzma_preset in /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so
-- Looking for lzma_lzma_preset in /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so - found
-- Found LibLZMA: /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so (found version "5.8.1")
-- Building with lzma support: /nix/store/swqs30pymm3ymv2qnkzs353xmpgr80jr-xz-5.8.1/lib/liblzma.so
-- Found LibELF...
--     ELF Lib: /nix/store/s00wdfaj0jzm91rjrvjzchrapb6366dw-elfutils-0.193-dev/include
--     ELF Include: /nix/store/5vlqyz0yh8rgb81m58kq3qjn6d5qabmn-elfutils-0.193/lib/libelf.so
-- Found GLIB: /nix/store/lp70a3fms2d1myir800dwhdyxnc0cfgg-glib-2.84.4-dev/include/glib-2.0;/nix/store/zqzyq9l84rfh3nv7cckh4q8ikl180h39-glib-2.84.4/lib/glib-2.0/include
-- Checking for one of the modules 'libusb-1.0'
-- Found LIBUSB: /nix/store/d2rmdjjvgzgz1r97sqxrnxn1qal4xrrx-libusb-1.0.29-dev/include/libusb-1.0
-- Using system gtest libraries
-- Building tests
-- OpenSSL found /nix/store/cz9k6nhxjppa1kmyf5npd0g8l89xzilw-openssl-3.5.2-dev/include /nix/store/0837wpkjb27cr70bi3pc4g2rw5v9r63l-openssl-3.5.2/lib/libssl.so;/nix/store/0837wpkjb27cr70bi3pc4g2rw5v9r63l-openssl-3.5.2/lib/libcrypto.so
-- Configuring incomplete, errors occurred!

@fabianhjr fabianhjr merged commit 3fa25e2 into NixOS:master Oct 7, 2025
33 of 35 checks passed
@trofi trofi deleted the libunarr-cmake-4-fix branch October 7, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@wegank wegank Awaiting requested review from wegank

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @fabianhjr