libvdpau-va-gl: update to latest git#449230
libvdpau-va-gl: update to latest git#449230haterdotdev wants to merge 2 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
| rev = "v${version}"; | ||
| sha256 = "0asndybfv8xb0fx73sjjw5kydqrahqkm6n04lh589pbf18s5qlld"; | ||
| rev = "a845e8720d900e4bcc89e7ee16106ce63b44af0d"; | ||
| sha256 = "sha256-CtpyWod+blqC3u12MaQyqFOXurCP5Rb2PYq7PoaoASA="; |
There was a problem hiding this comment.
Since we're touching this line anyway,
| sha256 = "sha256-CtpyWod+blqC3u12MaQyqFOXurCP5Rb2PYq7PoaoASA="; | |
| hash = "sha256-CtpyWod+blqC3u12MaQyqFOXurCP5Rb2PYq7PoaoASA="; |
| pname = "libvdpau-va-gl"; | ||
| version = "0.4.2"; | ||
| version = "git-a845e87"; |
There was a problem hiding this comment.
Please review our versioning guidelines. https://github.com/NixOS/nixpkgs/tree/master/pkgs#versioning
This should be 0.4.2-unstable-[whatever]
There was a problem hiding this comment.
Commit message should also follow the guidelines mentioned at the link above, and reformatting should not be its own commit.
There was a problem hiding this comment.
Commit message should also follow the guidelines mentioned at the link above, and reformatting should not be its own commit.
Sorry for that, i forgot to do that before pushing it.
There was a problem hiding this comment.
Please review our versioning guidelines. https://github.com/NixOS/nixpkgs/tree/master/pkgs#versioning
This should be
0.4.2-unstable-[whatever]
I'll fix that ASAP, thanks for your review, i'll take a better look into the conventions.
nixpkgs-ci
bot
removed
the
9.needs: reviewer
haterdotdev
force-pushed
the
libvdpau-va-gl-update
branch
2 times, most recently
from
b7507eb to
71c366c
Compare
Update to the latest commit. Fixes CMake incompatibility.
haterdotdev
force-pushed
the
libvdpau-va-gl-update
branch
from
71c366c to
69be2cd
Compare
2 participants
The old version fails to build with modern CMake versions. This update bumps the package to the latest upstream commit, which updates the CMakeFiles to fix the build.
Closes #448918
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.