discord-rpc: fix build with CMake 4; various: disable discord-rpc by marcin-serwin · Pull Request #449212 · NixOS/nixpkgs

marcin-serwin · 2025-10-06T18:04:39Z

discord-rpc is unmaintained upstream.

Related to: Tracking: Build Failures with CMake 4 #445447

Things done

Add a 👍 reaction to pull requests you find important.

Signed-off-by: Marcin Serwin <[email protected]>

felixalbrigtsen · 2025-10-06T18:26:47Z

Accounting for #445447 in the actual mudlet package as well, mudlet builds fine like this without discord-rpc. LGTM 🚀

WheelsForReals · 2025-10-06T19:11:58Z

Seems good to me for Parallel Launcher, though we could also just remove it from the derivation entirely. It appears PL doesn't use the nixpkgs version of the library at runtime at all. PL actually downloads its own precompiled version of the lib to /home/$USER/.local/share/parallel-launcher/plugins and dlopens that one at runtime instead.

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 449212 --package parallel-launcher
Commit: 297f8fb901ffc15d1a1f425b4875c50247dcc5c5

`x86_64-linux`

✅ 1 package built:

parallel-launcher

keenanweaver

openrct2 is still failing, but that's because of innoextract. #449252 should address

matteo-pacini · 2025-10-07T13:44:51Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449212
Commit: 297f8fb901ffc15d1a1f425b4875c50247dcc5c5 (subsequent changes)
Merge: 7f72f226e17c22d03d18a9bb9fe74f35741b602b

Logs: https://github.com/matteo-pacini/nixpkgs-review-gha/actions/runs/18314219557

`x86_64-linux`

❌ 2 packages failed to build:

mudlet
openrct2

✅ 4 packages built:

discord-rpc
parallel-launcher
rmg
rmg-wayland

Error logs: `x86_64-linux`

mudlet

patching file src/CMakeLists.txt Hunk #1 succeeded at 524 (offset -38 lines). Running phase: updateAutotoolsGnuConfigScriptsPhase @nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" } Updating Autotools / GNU config script to a newer upstream version: ./3rdparty/edbee-lib/vendor/onig/config.sub Updating Autotools / GNU config script to a newer upstream version: ./3rdparty/edbee-lib/vendor/onig/config.guess Running phase: configurePhase @nix { "action": "setPhase", "phase": "configurePhase" } cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/share/doc/mudlet -DCMAKE_INSTALL_INFODIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/include -DCMAKE_INSTALL_SBINDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/mrwn1f5p89l1g0ldbffyxgisjb4gp1bi-mudlet-4.17.2 -DCMAKE_SKIP_BUILD_RPATH=ON CMake Error at CMakeLists.txt:36 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.

Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

-- Configuring incomplete, errors occurred!

`aarch64-linux`

❌ 2 packages failed to build:

mudlet
openrct2

✅ 3 packages built:

discord-rpc
rmg
rmg-wayland

Error logs: `aarch64-linux`

mudlet

patching file src/CMakeLists.txt Hunk #1 succeeded at 524 (offset -38 lines). Running phase: updateAutotoolsGnuConfigScriptsPhase @nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" } Updating Autotools / GNU config script to a newer upstream version: ./3rdparty/edbee-lib/vendor/onig/config.sub Updating Autotools / GNU config script to a newer upstream version: ./3rdparty/edbee-lib/vendor/onig/config.guess Running phase: configurePhase @nix { "action": "setPhase", "phase": "configurePhase" } cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/share/doc/mudlet -DCMAKE_INSTALL_INFODIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/include -DCMAKE_INSTALL_SBINDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/69vxrbknrcbjclavanhdqcgd8pbch946-mudlet-4.17.2 -DCMAKE_SKIP_BUILD_RPATH=ON CMake Error at CMakeLists.txt:36 (cmake_minimum_required): Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value. Or, use the <min>...<max> syntax
to tell CMake that the project requires at least <min> but has been updated
to work with policies introduced by <max> or earlier.

Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

-- Configuring incomplete, errors occurred!

`x86_64-darwin` (sandbox = true)

❌ 2 packages failed to build:

discord-rpc
mudlet

Error logs: `x86_64-darwin`

discord-rpc

Manually-specified variables were not used by the project:

BUILD_TESTING
CMAKE_EXPORT_NO_PACKAGE_REGISTRY
CMAKE_FIND_USE_PACKAGE_REGISTRY
CMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY
CMAKE_POLICY_DEFAULT_CMP0025

-- Build files have been written to: /nix/build/nix-9750-505625855/source/build
cmake: enabled parallel building
cmake: enabled parallel installing
configurePhase completed in 36 seconds
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
build flags: -j3 SHELL=/nix/store/j3wkpf582ngf1brv85jbgi1fk6c9lspq-bash-5.3p3/bin/bash
[ 0%] Built target clangformat
[ 16%] Building CXX object src/CMakeFiles/discord-rpc.dir/serialization.cpp.o
[ 33%] Building CXX object src/CMakeFiles/discord-rpc.dir/rpc_connection.cpp.o
[ 50%] Building CXX object src/CMakeFiles/discord-rpc.dir/discord_rpc.cpp.o

`aarch64-darwin` (sandbox = true)

❌ 2 packages failed to build:

discord-rpc
mudlet

Error logs: `aarch64-darwin`

discord-rpc

CMake Warning: Manually-specified variables were not used by the project:

BUILD_TESTING
CMAKE_EXPORT_NO_PACKAGE_REGISTRY
CMAKE_FIND_USE_PACKAGE_REGISTRY
CMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY
CMAKE_POLICY_DEFAULT_CMP0025

-- Build files have been written to: /nix/build/nix-7511-3336183747/source/build
cmake: enabled parallel building
cmake: enabled parallel installing
Running phase: buildPhase
@nix { "action": "setPhase", "phase": "buildPhase" }
build flags: -j3 SHELL=/nix/store/xhsnsmvh1ka5mxszd1psxq36vaanb8jy-bash-5.3p3/bin/bash
[ 0%] Built target clangformat
[ 16%] Building CXX object src/CMakeFiles/discord-rpc.dir/discord_rpc.cpp.o
[ 33%] Building CXX object src/CMakeFiles/discord-rpc.dir/rpc_connection.cpp.o
[ 50%] Building CXX object src/CMakeFiles/discord-rpc.dir/serialization.cpp.o

marcin-serwin · 2025-10-07T15:21:55Z

I can't reproduce the darwin build failure, I think it's unlikely that it's caused by this change.

fxzzi

lgtm

SuperSandro2000 · 2025-10-09T12:38:26Z

I don't get why we disable discord-rpc in all those packages. Just because it is unmaintained?

surfaceflinger · 2025-10-09T13:32:08Z

It appears PL doesn't use the nixpkgs version of the library at runtime at all. PL actually downloads its own precompiled version of the lib to /home/$USER/.local/share/parallel-launcher/plugins and dlopens that one at runtime instead.

Is this the only thing that PL downloads? Because if yes, then it would be good to patch it out/disable it during build to use discord-rpc from system if there's an option.

marcin-serwin · 2025-10-09T14:44:13Z

I don't get why we disable discord-rpc in all those packages. Just because it is unmaintained?

Yep, I'd rather avoid unmaintained optional dependencies and drop the discord-rpc the next time it breaks.

marcin-serwin added 5 commits October 6, 2025 19:59

discord-rpc: fix build with CMake 4

d64d734

Signed-off-by: Marcin Serwin <[email protected]>

mudlet: disable discord-rpc

e904194

Signed-off-by: Marcin Serwin <[email protected]>

rmg: disable discord-rpc

12fd35f

Signed-off-by: Marcin Serwin <[email protected]>

openrct2: disable discord-rpc

9721a81

Signed-off-by: Marcin Serwin <[email protected]>

parallel-launcher: disable discord-rpc

297f8fb

Signed-off-by: Marcin Serwin <[email protected]>

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: games Gaming on NixOS labels Oct 6, 2025

nix-owners bot requested review from WheelsForReals, felixalbrigtsen, keenanweaver, kylerisse, oxzi and pstn October 6, 2025 18:10

WheelsForReals approved these changes Oct 6, 2025

View reviewed changes

nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 6, 2025

keenanweaver approved these changes Oct 7, 2025

View reviewed changes

nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 7, 2025

LordGrimmauld mentioned this pull request Oct 7, 2025

Tracking: Build Failures with CMake 4 #445447

Open

fxzzi approved these changes Oct 8, 2025

View reviewed changes

nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 8, 2025

vcunat added this pull request to the merge queue Oct 9, 2025

Merged via the queue into NixOS:master with commit 4b3a7fb Oct 9, 2025
38 of 40 checks passed

marcin-serwin deleted the push-vmvxxquywulx branch October 11, 2025 11:24

WheelsForReals mentioned this pull request Oct 17, 2025

parallel-launcher: 8.3.0 -> 9.0.2 #452803

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

discord-rpc: fix build with CMake 4; various: disable discord-rpc#449212

discord-rpc: fix build with CMake 4; various: disable discord-rpc#449212
vcunat merged 5 commits intoNixOS:masterfrom
marcin-serwin:push-vmvxxquywulx

marcin-serwin commented Oct 6, 2025 •

edited by Sigmanificient

Loading

Uh oh!

felixalbrigtsen commented Oct 6, 2025

Uh oh!

WheelsForReals commented Oct 6, 2025

Uh oh!

keenanweaver left a comment

Uh oh!

matteo-pacini commented Oct 7, 2025

Uh oh!

marcin-serwin commented Oct 7, 2025

Uh oh!

fxzzi left a comment

Uh oh!

SuperSandro2000 commented Oct 9, 2025

Uh oh!

surfaceflinger commented Oct 9, 2025

Uh oh!

marcin-serwin commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

marcin-serwin commented Oct 6, 2025 • edited by Sigmanificient Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

felixalbrigtsen commented Oct 6, 2025

Uh oh!

WheelsForReals commented Oct 6, 2025

nixpkgs-review result

x86_64-linux

Uh oh!

keenanweaver left a comment

Choose a reason for hiding this comment

Uh oh!

matteo-pacini commented Oct 7, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

marcin-serwin commented Oct 7, 2025

Uh oh!

fxzzi left a comment

Choose a reason for hiding this comment

Uh oh!

SuperSandro2000 commented Oct 9, 2025

Uh oh!

surfaceflinger commented Oct 9, 2025

Uh oh!

marcin-serwin commented Oct 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

marcin-serwin commented Oct 6, 2025 •

edited by Sigmanificient

Loading

`nixpkgs-review` result

`x86_64-linux`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)