skytemple, armips: fix compilation and remove indirectly vulnerable webkitgtk_4_0#449192
Merged
LordGrimmauld merged 4 commits intoNixOS:masterfrom Oct 14, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
|
marius851000
force-pushed
the
skytemple_remove_webkit
branch
from
b71ac1c to
2f76ea6
Compare
marius851000
changed the title
nixpkgs-ci
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
@Sigmanificient Good point. I forgot to fork my branch from an up-to-date master. Or something. Its now updated with a fix to armips and explorerscript (and I re-did my test, everything still working as expected). I also took the occasion to update my email in the maintainers list. |
dotlambda
reviewed
Oct 9, 2025
nixpkgs-ci
bot
removed
the
9.needs: reviewer
marius851000
force-pushed
the
skytemple_remove_webkit
branch
from
a41c39f to
d4ffcfe
Compare
Contributor
|
This seems relevant for #360897 too |
LordGrimmauld
approved these changes
Oct 14, 2025
Contributor
LordGrimmauld
left a comment
LordGrimmauld
left a comment
There was a problem hiding this comment.
These four changes are totally disconnected and unrelated. I want both the cmake build fix as well as the webkitgtk_4_0 drop, and the diff looks fine. Personally i'd have preferred this split across multiple PRs, but if the changes are okay i won't complain too much.
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
|
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Removed the webkit dependancy on SkyTemple. It use libsoup2, which is marked as vulnerable and outdated, and won’t compiled. SkyTemple work fine without it, only using it to display some graph, that are otherwised rendered as image in-app and offer the option to open them in the web browser.
I also noticed problem with an aiohttp update error in the portrait browser. I might fix that later, when I have more time to make a fix. (it is otherwise possible to manually download them from https://sprites.pmdcollab.org or https://nsc.pmdcollab.org and import them manually).
I tried to update to 4.1 which does use libsoup3, but it crash when it try to render the graph with some Wayland/X error (tested with both). I suspect it might also happen with 4.0, but I didn’t given I had trouble compiling it, as it doesn’t appear to respect the core limit I ask it (and otherwise eats up all the RAM). Might be an error on my side.
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.