reaper-sws-extension: 2.14.0.3 -> 2.14.0.7 by mksafavi · Pull Request #449183 · NixOS/nixpkgs

mksafavi · 2025-10-06T16:06:06Z

Things done

Add a 👍 reaction to pull requests you find important.

mksafavi · 2025-10-06T16:36:24Z

Hi @pancaek
I don't know if it's possible to cross compile a darwin package on x86 nixos. So I probably wouldn't be able to finish this.
Could you build it on your machine?

pancaek · 2025-10-06T18:12:56Z

I'll take a look tonight!

pancaek

I think these hashes are right now, but looks like the installPhase might be broken on darwin for some reason. Not sure how it didn't get caught before but I need to poke at that too. Should just be moving files around, not sure what I'm not seeing here.

pkgs/by-name/re/reaper-sws-extension/darwin.nix

pancaek · 2025-10-07T02:57:04Z

Managed to make it work with a very cursed installPhase for darwin, I might be able make a PR onto your merge request to at least get a working darwin version. Either that or you can mark darwin broken here and I can unbreak it in a followup PR. Ideally I'd make the fix a lot less terrible, but as long as it works I guess 🤷

mksafavi · 2025-10-07T07:17:56Z

Managed to make it work with a very cursed installPhase for darwin, I might be able make a PR onto your merge request to at least get a working darwin version. Either that or you can mark darwin broken here and I can unbreak it in a followup PR. Ideally I'd make the fix a lot less terrible, but as long as it works I guess 🤷

Wouldn't it be easier if I give you access to my fork?
We can also close this PR and you open a new one.
Either way works for me. 👍

update to version 2.14.0.7 and marked darwin build as broken Co-authored-by: pancaek <[email protected]>

pancaek · 2025-10-14T22:23:37Z

I've PR'ed your repo!

mksafavi · 2025-10-15T07:14:11Z

I've PR'ed your repo!

Oh! Thanks for the heads up. I didn't get any notifications for it.

Edit. I slightly changed your commit. Removed the broken mark and formatted the commit message.

pancaek

LGTM

nixos-discourse · 2025-10-17T18:51:32Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5958

yzhou216

Could you please apply the CMake hotfix from #452817? Let's try to get this one merged instead, and I'll close #452817 once it's applied. Thanks!

yzhou216 · 2025-10-17T20:21:12Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449183
Commit: 24f0b50927e13873a91e8080d31f042aec456e52 (subsequent changes)
Merge: 085a9865a500ef11c5a41ddc831f1abfcbb05c25

Logs: https://github.com/yzhou216/nixpkgs-review-gha/actions/runs/18603763242

Download packages from cache:

x86_64-linux

nix-store -r --add-root nixpkgs-pr-449183-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/wpldipsf96wq09gyvgc8niwx0fp7n9wm-reaper-sws-extension-2.14.0.7

aarch64-linux

nix-store -r --add-root nixpkgs-pr-449183-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://yzhou216.cachix.org' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  yzhou216.cachix.org-1:O7nGwQnLGGBGE8zYFMipVzPVN956FcV57y9SqwEP+O8=
  ' \
  /nix/store/cgqp8krbj4p545j6871cjghagf491myp-reaper-sws-extension-2.14.0.7

`x86_64-linux`

✅ 1 package built:

reaper-sws-extension

`aarch64-linux`

✅ 1 package built:

reaper-sws-extension

`x86_64-darwin` (sandbox = true)

❌ 1 package failed to build:

reaper-sws-extension

Error logs: `x86_64-darwin`

reaper-sws-extension

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/f68jrdzl5qyixcn1k9a007glbqjvsv2h-reaper_sws-x86_64.dylib
unpacking source archive /nix/store/5hd3674ldcj29zc0idkg0g7mg0af03p3-sws_python64.py
unpacking source archive /nix/store/14k1045ia797nmyb7gr0x17fxlxl5n6h-sws_python32.py
unpacker appears to have produced no directories

`aarch64-darwin` (sandbox = true)

❌ 1 package failed to build:

reaper-sws-extension

Error logs: `aarch64-darwin`

reaper-sws-extension

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/94f6h6bifpih88hyvffhnrwvf7jw6nnk-reaper_sws-arm64.dylib
unpacking source archive /nix/store/5hd3674ldcj29zc0idkg0g7mg0af03p3-sws_python64.py
unpacking source archive /nix/store/14k1045ia797nmyb7gr0x17fxlxl5n6h-sws_python32.py
unpacker appears to have produced no directories

mksafavi · 2025-10-17T20:36:42Z

Could you please apply the CMake hotfix from #452817? Let's try to get this one merged instead, and I'll close #452817 once it's applied. Thanks!

Hi.
Is the patch still necessary? I get the cmake error on 2.14.0.3. But version 2.14.0.7 compiles for me . If it's still needed let me know, I'll add your commit to this PR.

mksafavi · 2025-10-17T20:47:53Z

@yzhou216 The Mac version is broken. We could use some help there as we don't have any Mac machines.

Quoting @pancaek's comment from the other pr:

dontUnpack=true; stops the files from being moved to the right place, and I'd originally set dontUnpack because the dylib made the standard unpackPhase fail. We may need to patch the dylib with libraries futher but I can't test that without a darwin machine.

We might still want to leave it marked broken until someone on darwin can test it for me, not sure what the policy is for that.

yzhou216 · 2025-10-17T20:51:05Z

Could you please apply the CMake hotfix from #452817? Let's try to get this one merged instead, and I'll close #452817 once it's applied. Thanks!

Hi. Is the patch still necessary? I get the cmake error on 2.14.0.3. But version 2.14.0.7 compiles for me . If it's still needed let me know, I'll add your commit to this PR.

Weird, the build failed without the CMake patch on my machine when I last checked. Please see #452617.

yzhou216 · 2025-10-17T20:52:54Z

@yzhou216 The Mac version is broken. We could use some help there as we don't have any Mac machines.

Quoting @pancaek's comment from the other pr:

dontUnpack=true; stops the files from being moved to the right place, and I'd originally set dontUnpack because the dylib made the standard unpackPhase fail. We may need to patch the dylib with libraries futher but I can't test that without a darwin machine.
We might still want to leave it marked broken until someone on darwin can test it for me, not sure what the policy is for that.

I can try to debug it on my friend's Mac machine in the evening. BTW, do you have nixpkgs-review-gha setup?

mksafavi · 2025-10-17T21:01:27Z

Could you please apply the CMake hotfix from #452817? Let's try to get this one merged instead, and I'll close #452817 once it's applied. Thanks!

Hi. Is the patch still necessary? I get the cmake error on 2.14.0.3. But version 2.14.0.7 compiles for me . If it's still needed let me know, I'll add your commit to this PR.

Weird, the build failed without the CMake patch on my machine when I last checked. Please see #452617.

I think I got the same error as #452617 on my CI a couple of weeks ago.
They added the minimum version check upstream reaper-oss/sws@ebde5df. I guess that should handle it. right?
I'll try it again tomorrow to make sure 👍

mksafavi · 2025-10-17T21:06:25Z

I can try to debug it on my friend's Mac machine in the evening.

👍

BTW, do you have nixpkgs-review-gha setup?

Oh, I didn't know about that project. I'll set it up. Thanks!!

SuperSandroBot · 2025-10-18T00:20:14Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449183
Commit: 24f0b50927e13873a91e8080d31f042aec456e52 (subsequent changes)
Merge: 2eacc001a9b5ae97ad65f76b51f611da0e4dd534

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18607786472

`x86_64-linux`

✅ 1 package built:

reaper-sws-extension

`aarch64-linux`

✅ 1 package built:

reaper-sws-extension

`x86_64-darwin` (sandbox = true)

❌ 1 package failed to build:

reaper-sws-extension

Error logs: `x86_64-darwin`

reaper-sws-extension

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/f68jrdzl5qyixcn1k9a007glbqjvsv2h-reaper_sws-x86_64.dylib
unpacking source archive /nix/store/5hd3674ldcj29zc0idkg0g7mg0af03p3-sws_python64.py
unpacking source archive /nix/store/14k1045ia797nmyb7gr0x17fxlxl5n6h-sws_python32.py
unpacker appears to have produced no directories

`aarch64-darwin` (sandbox = true)

❌ 1 package failed to build:

reaper-sws-extension

Error logs: `aarch64-darwin`

reaper-sws-extension

Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/94f6h6bifpih88hyvffhnrwvf7jw6nnk-reaper_sws-arm64.dylib
unpacking source archive /nix/store/5hd3674ldcj29zc0idkg0g7mg0af03p3-sws_python64.py
unpacking source archive /nix/store/14k1045ia797nmyb7gr0x17fxlxl5n6h-sws_python32.py
unpacker appears to have produced no directories

mksafavi requested a review from pancaek October 6, 2025 16:11

pancaek suggested changes Oct 6, 2025

View reviewed changes

pkgs/by-name/re/reaper-sws-extension/darwin.nix Outdated Show resolved Hide resolved

pkgs/by-name/re/reaper-sws-extension/darwin.nix Outdated Show resolved Hide resolved

pkgs/by-name/re/reaper-sws-extension/darwin.nix Outdated Show resolved Hide resolved

reaper-sws-extension: 2.14.0.3 -> 2.14.0.7

17151f0

update to version 2.14.0.7 and marked darwin build as broken Co-authored-by: pancaek <[email protected]>

mksafavi force-pushed the reaper-sws-extension branch from c652bc4 to 17151f0 Compare October 10, 2025 12:09

mksafavi marked this pull request as ready for review October 10, 2025 12:11

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 10, 2025

l1npengtul mentioned this pull request Oct 12, 2025

reaper-sws-extensions: 2.14.0.3 -> 2.14.0.7 #451217

Closed

13 tasks

reaper-sws-extension: fix darwin eval

24f0b50

mksafavi force-pushed the reaper-sws-extension branch from 6b13b07 to 24f0b50 Compare October 15, 2025 07:17

mksafavi requested review from pancaek and pyrox0 October 15, 2025 07:20

nixpkgs-ci bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 15, 2025

pancaek approved these changes Oct 16, 2025

View reviewed changes

nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 16, 2025

pancaek mentioned this pull request Oct 17, 2025

reaper-sws-extension: 2.14.0.3 -> 2.14.0.7 #452817

Closed

13 tasks

yzhou216 suggested changes Oct 17, 2025

View reviewed changes

SuperSandro2000 added this pull request to the merge queue Oct 18, 2025

Merged via the queue into NixOS:master with commit 639910d Oct 18, 2025
30 checks passed

Sigmanificient mentioned this pull request Oct 25, 2025

Tracking: Build Failures with CMake 4 #445447

Open

Uh oh!

Conversation

mksafavi commented Oct 6, 2025

Things done

Uh oh!

mksafavi commented Oct 6, 2025

Uh oh!

pancaek commented Oct 6, 2025

Uh oh!

pancaek left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pancaek commented Oct 7, 2025

Uh oh!

mksafavi commented Oct 7, 2025

Uh oh!

pancaek commented Oct 14, 2025

Uh oh!

mksafavi commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pancaek left a comment

Choose a reason for hiding this comment

Uh oh!

nixos-discourse commented Oct 17, 2025

Uh oh!

yzhou216 left a comment

Choose a reason for hiding this comment

Uh oh!

yzhou216 commented Oct 17, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

mksafavi commented Oct 17, 2025

Uh oh!

mksafavi commented Oct 17, 2025

Uh oh!

yzhou216 commented Oct 17, 2025

Uh oh!

yzhou216 commented Oct 17, 2025

Uh oh!

mksafavi commented Oct 17, 2025

Uh oh!

mksafavi commented Oct 17, 2025

Uh oh!

SuperSandroBot commented Oct 18, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mksafavi commented Oct 15, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)