Skip to content

usbtop: fix build against CMake >= 4.0#449129

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
mjoerg:usbtop-fix-cmake-4
Oct 7, 2025
Merged

usbtop: fix build against CMake >= 4.0#449129
Sigmanificient merged 2 commits intoNixOS:masterfrom
mjoerg:usbtop-fix-cmake-4

Conversation

@mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Oct 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review
Commit: dabf8f709e215305884c53211b461a72ca64b895


x86_64-linux

✅ 1 package built:
  • usbtop

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 6, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449129
Commit: dabf8f709e215305884c53211b461a72ca64b895 (subsequent changes)
Merge: 785c0b31d1a21352215adfd97945ec4234884321

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18307657959


x86_64-linux

✅ 1 package built:
  • usbtop

aarch64-linux

✅ 1 package built:
  • usbtop

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 9d0b8ae Oct 7, 2025
33 of 35 checks passed
@panchoh
Copy link
Contributor

panchoh commented Oct 8, 2025

Thanks for fixing this, @joerg!

Please be aware of the recommendations offered in #445447 (point 3 at the top, further explained in @LordGrimmauld’s comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants