Skip to content

autopanosiftc: drop#449025

Merged
fabianhjr merged 2 commits intoNixOS:masterfrom
alois31:push-txypypvrywrx
Oct 7, 2025
Merged

autopanosiftc: drop#449025
fabianhjr merged 2 commits intoNixOS:masterfrom
alois31:push-txypypvrywrx

Conversation

@alois31
Copy link
Contributor

@alois31 alois31 commented Oct 6, 2025

It is unmaintained upstream, with the last release being from 2009, and fails to build with CMake 4. Drop the package, along with its only known usage in hugin, where it has been considered deprecated upstream since 2011.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 6, 2025
@nix-owners nix-owners bot requested a review from hrdinka October 6, 2025 05:24
@phanirithvij
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 449025

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/18271536254


x86_64-linux

✅ 2 packages built:
  • digikam
  • hugin

aarch64-linux

✅ 2 packages built:
  • digikam
  • hugin

@vs49688 vs49688 mentioned this pull request Oct 7, 2025
3 tasks
@toastal
Copy link
Contributor

toastal commented Oct 7, 2025

Related to: #445447

Built/worked for me as an overlay

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 7, 2025
Copy link
Member

@fabianhjr fabianhjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a throw to aliases indicating reason for removal

@alois31 alois31 force-pushed the push-txypypvrywrx branch 2 times, most recently from f1680b3 to 5059e36 Compare October 7, 2025 16:11
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 7, 2025
Usage of autopanosiftc is considered deprecated by upstream since 2011 [1] in
favour of a built-in tool. Remove the dependency.

[1] https://hugin.sourceforge.io/releases/2011.0.0/en.shtml#:~:text=Control%20point%20generators
It is unmaintained upstream, with the last release being from 2009, and fails
to build with CMake 4. Its only known usage (in hugin, where it has been
considered deprecated upstream since 2011) has been removed. Drop the package.
@alois31 alois31 force-pushed the push-txypypvrywrx branch from 5059e36 to b98fb4b Compare October 7, 2025 16:24
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 7, 2025
autoconf213 = throw "'autoconf213' has been removed in favor of 'autoconf'"; # Added 2025-07-21
autoconf264 = throw "'autoconf264' has been removed in favor of 'autoconf'"; # Added 2025-07-21
automake111x = throw "'automake111x' has been removed in favor of 'automake'"; # Added 2025-07-21
autopanosiftc = throw "'autopanosiftc' has been removed, as it is unmaintained upstream"; # Added 2025-10-07
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, i like to give info about since when something was unmaintained. 2009 is much worse than 2024, for example.

Suggested change
autopanosiftc = throw "'autopanosiftc' has been removed, as it is unmaintained upstream"; # Added 2025-10-07
autopanosiftc = throw "'autopanosiftc' has been removed, as it is unmaintained upstream since <year>"; # Added 2025-10-07

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 7, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 7, 2025
@fabianhjr fabianhjr added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit 40106ff Oct 7, 2025
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants