Merged
Conversation
Member
|
3 tasks
toastal
approved these changes
Oct 7, 2025
Contributor
|
Related to: #445447 Built/worked for me as an overlay |
fabianhjr
requested changes
Oct 7, 2025
Member
fabianhjr
left a comment
There was a problem hiding this comment.
Please add a throw to aliases indicating reason for removal
f1680b3 to
5059e36
Compare
Usage of autopanosiftc is considered deprecated by upstream since 2011 [1] in favour of a built-in tool. Remove the dependency. [1] https://hugin.sourceforge.io/releases/2011.0.0/en.shtml#:~:text=Control%20point%20generators
It is unmaintained upstream, with the last release being from 2009, and fails to build with CMake 4. Its only known usage (in hugin, where it has been considered deprecated upstream since 2011) has been removed. Drop the package.
5059e36 to
b98fb4b
Compare
LordGrimmauld
approved these changes
Oct 7, 2025
| autoconf213 = throw "'autoconf213' has been removed in favor of 'autoconf'"; # Added 2025-07-21 | ||
| autoconf264 = throw "'autoconf264' has been removed in favor of 'autoconf'"; # Added 2025-07-21 | ||
| automake111x = throw "'automake111x' has been removed in favor of 'automake'"; # Added 2025-07-21 | ||
| autopanosiftc = throw "'autopanosiftc' has been removed, as it is unmaintained upstream"; # Added 2025-10-07 |
Contributor
There was a problem hiding this comment.
Nit, i like to give info about since when something was unmaintained. 2009 is much worse than 2024, for example.
Suggested change
| autopanosiftc = throw "'autopanosiftc' has been removed, as it is unmaintained upstream"; # Added 2025-10-07 | |
| autopanosiftc = throw "'autopanosiftc' has been removed, as it is unmaintained upstream since <year>"; # Added 2025-10-07 |
fabianhjr
approved these changes
Oct 7, 2025
qweered
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is unmaintained upstream, with the last release being from 2009, and fails to build with CMake 4. Drop the package, along with its only known usage in hugin, where it has been considered deprecated upstream since 2011.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.