Skip to content

brlaser: add patch for cmake minimum version#448946

Merged
andresilva merged 1 commit intoNixOS:masterfrom
andresilva:brlaser-cmake-fix
Oct 8, 2025
Merged

brlaser: add patch for cmake minimum version#448946
andresilva merged 1 commit intoNixOS:masterfrom
andresilva:brlaser-cmake-fix

Conversation

@andresilva
Copy link
Member

@andresilva andresilva commented Oct 5, 2025

Closes #449475

Related #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@andresilva
Copy link
Member Author

Fixes build:

error: Cannot build '/nix/store/v4imhgy6bcns0128dm3rr7zz53g13qn5-brlaser-6.2.7.drv'.
       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7
       Last 18 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/xy7s5pvkf8zrdjcxvnfhh5yn6sw0bdml-source
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/share/doc/brlaser -DCMAKE_INSTALL_INFODIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/include -DCMAKE_INSTALL_SBINDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/xw77ck0psjddffhli4y05ry5xma9hfkz-brlaser-6.2.7 -DCUPS_SERVER_BIN=lib/cups -DCUPS_DATA_DIR=share/cups
       > CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
       >   Compatibility with CMake < 3.5 has been removed from CMake.
       >
       >   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
       >   to tell CMake that the project requires at least <min> but has been updated
       >   to work with policies introduced by <max> or earlier.
       >
       >   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
       >
       >
       > -- Configuring incomplete, errors occurred!
       For full logs, run:
         nix log /nix/store/v4imhgy6bcns0128dm3rr7zz53g13qn5-brlaser-6.2.7.drv

@andresilva
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 448946
Commit: 0383b4242242cdf893118cd224f367f787a72632


x86_64-linux

✅ 1 package built:
  • brlaser

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 5, 2025
@nix-owners nix-owners bot requested a review from onny October 5, 2025 20:24
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 5, 2025
@andresilva
Copy link
Member Author

Thanks @JarvisCraft, updated!

@andresilva
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 448946
Commit: c9c2a2f91687c76a9deabb168c18d16612c68432


x86_64-linux

✅ 1 package built:
  • brlaser

@matteo-pacini
Copy link
Contributor

Copy link
Contributor

@matteo-pacini matteo-pacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 8, 2025
@andresilva andresilva enabled auto-merge October 8, 2025 07:42
@andresilva andresilva added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit d53a6ed Oct 8, 2025
31 of 35 checks passed
@andresilva andresilva deleted the brlaser-cmake-fix branch October 8, 2025 07:45
catbrained added a commit to catbrained/dotfiles that referenced this pull request Oct 9, 2025
There currently is a build failure due to an CMAKE update.
There already is a fix, just need to wait for it to hit nixos-unstable.

See: NixOS/nixpkgs#448946

Signed-off-by: Linda Siemons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: brlaser

3 participants