Skip to content

qt5.qtdeclarative: Make "RegisterID" patch unconditional#448904

Merged
K900 merged 1 commit intoNixOS:stagingfrom
dramforever:qt5-qtdeclarative-registerid
Oct 5, 2025
Merged

qt5.qtdeclarative: Make "RegisterID" patch unconditional#448904
K900 merged 1 commit intoNixOS:stagingfrom
dramforever:qt5-qtdeclarative-registerid

Conversation

@dramforever
Copy link
Contributor

@dramforever dramforever commented Oct 5, 2025

The patch was conditional to x86_64-darwin to fix staging-next without rebuilding too much. Now that the cycle is done, make it unconditional.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux (Rebased to master)
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dramforever
qt5.qtdeclarative: Make "RegisterID" patch unconditional
d493d7e 
The patch was conditional to x86_64-darwin to fix staging-next without
rebuilding too much. Now that the cycle is done, make it unconditional.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Oct 5, 2025
@K900 K900 enabled auto-merge October 5, 2025 16:59
@K900 K900 merged commit 7c839d1 into NixOS:staging Oct 5, 2025
31 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@K900 K900 Awaiting requested review from K900

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dramforever @K900