Skip to content

clblast: fix build with CMake 4#448902

Merged
fabianhjr merged 1 commit intoNixOS:masterfrom
LunNova:push-zulunprzyzpq
Oct 7, 2025
Merged

clblast: fix build with CMake 4#448902
fabianhjr merged 1 commit intoNixOS:masterfrom
LunNova:push-zulunprzyzpq

Conversation

@LunNova
Copy link
Member

@LunNova LunNova commented Oct 5, 2025 •
edited
Loading

Applying upstream patch from
CNugteren/CLBlast@dd714f1

Tracking issue for CMake 4 failures: #445447

This unbreaks ollama.

Fixes #449507

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 5, 2025
@nix-owners nix-owners bot requested a review from Tungsten842 October 5, 2025 16:42
@LunNova LunNova requested a review from prusnak October 5, 2025 17:43
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 5, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 448902
Commit: a1190a306959dc135cbb41119b65e5b8a57f3cc1 (subsequent changes)
Merge: 9dfcab14a66100fbe63719843073e07eebd0bbc4

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18263926851

x86_64-linux

❌ 1 package failed to build:
  • ollama-rocm
✅ 2 packages built:
  • clblast
  • koboldcpp

aarch64-linux

✅ 2 packages built:
  • clblast
  • koboldcpp

@LunNova
Copy link
Member Author

LunNova commented Oct 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 448902
Commit: a1190a306959dc135cbb41119b65e5b8a57f3cc1

x86_64-linux

✅ 3 packages built:
  • clblast
  • koboldcpp
  • ollama-rocm

@LunNova
Copy link
Member Author

LunNova commented Oct 5, 2025

@Sigmanificient your ollama-rocm failure is because hipblaslt isn't cached yet and that building in a github actions run is doomed due to resource requirements

@LunNova LunNova requested a review from Sigmanificient October 5, 2025 22:22
@fabianhjr fabianhjr merged commit 2bbf7ca into NixOS:master Oct 7, 2025
33 of 35 checks passed
@LunNova LunNova mentioned this pull request Oct 7, 2025
Closed
3 tasks
@yayayayaka yayayayaka mentioned this pull request Oct 8, 2025
Open
nukdokplex added a commit to nukdokplex/ncaa that referenced this pull request Oct 10, 2025
@nukdokplex
overlays: fix clblast build with cmake 4
0a61404 
adaptation of NixOS/nixpkgs#448902
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianhjr fabianhjr fabianhjr approved these changes

@Tungsten842 Tungsten842 Awaiting requested review from Tungsten842

@prusnak prusnak Awaiting requested review from prusnak

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: clblast

3 participants

@LunNova @Sigmanificient @fabianhjr