Skip to content

postgresql_{17,18}: fix build#448817

Merged
Ma27 merged 1 commit intoNixOS:stagingfrom
Ma27:fix-postgresql-build
Oct 5, 2025
Merged

postgresql_{17,18}: fix build#448817
Ma27 merged 1 commit intoNixOS:stagingfrom
Ma27:fix-postgresql-build

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 5, 2025

After a recent update of libxml2 the build fails with

/nix/store/casz7al9kpkg52sn156h6slqijwkybqj-libxml2-2.15.0-bin/bin/xmllint --nonet --path . --path . --output postgres-full.xml --noent --valid postgres.sgml
ref/pg_combinebackup.sgml:287: validity error : standalone: normalization of attribute linkend on xref by external subset declaration

state of the cluster using is

Reported in #448752 (not closing on purpose since the issue is actually about another problem).

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Ma27
postgresql_{17,18}: fix build
9da1bc5 
After a recent update of libxml2 the build fails with

    /nix/store/casz7al9kpkg52sn156h6slqijwkybqj-libxml2-2.15.0-bin/bin/xmllint --nonet --path . --path . --output postgres-full.xml --noent --valid postgres.sgml
    ref/pg_combinebackup.sgml:287: validity error : standalone: normalization of attribute linkend on xref by external subset declaration
   state of the cluster using <xref linkend="app-pgchecksums "/> is

Reported in NixOS#448752 (not closing on purpose since the issue is actually
about another problem).
@Ma27 Ma27 requested a review from wolfgangwalther October 5, 2025 11:11
wolfgangwalther
wolfgangwalther approved these changes Oct 5, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, didn't build.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 5, 2025
@nix-owners nix-owners bot requested a review from thoughtpolice October 5, 2025 11:16
@Ma27 Ma27 merged commit 83b6e89 into NixOS:staging Oct 5, 2025
34 of 38 checks passed
@Ma27 Ma27 deleted the fix-postgresql-build branch October 5, 2025 11:39
@h0nIg h0nIg mentioned this pull request Oct 6, 2025
Closed
3 tasks
@wolfgangwalther wolfgangwalther mentioned this pull request Oct 7, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ma27 @wolfgangwalther