[staging-next] qt5.qtdeclarative: Fix build on x86_64-darwin#448633
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Oct 5, 2025
Merged
Conversation
Even though this patch is really for Qt 6, the code affected was unchanged, and the patch applies cleanly. Patch is temporarily conditional on x86_64-darwin to avoid extra rebuilds on staging-next.
Contributor
Author
|
I can't believe it either, but yes, you really can just apply a Qt 6 patch to Qt 5 unchanged. Sometimes. |
nixpkgs-ci
bot
added
10.rebuild-darwin: 501+
nix-owners
bot
requested review from
K900,
NickCao,
SuperSandro2000 and
ttuegel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even though this patch is really for Qt 6, the code affected was unchanged, and the patch applies cleanly.
Patch is temporarily conditional on x86_64-darwin to avoid extra rebuilds on staging-next.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.