Skip to content

ocamlPackages.synchronizer: init at 0.1#448246

Merged
vbgl merged 2 commits intoNixOS:masterfrom
redianthus:synchronizer
Oct 7, 2025
Merged

ocamlPackages.synchronizer: init at 0.1#448246
vbgl merged 2 commits intoNixOS:masterfrom
redianthus:synchronizer

Conversation

@redianthus
Copy link
Member

@redianthus redianthus commented Oct 3, 2025

Hi,

This is the first release of the synchronizer OCaml library.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Oct 3, 2025
@nix-owners nix-owners bot requested a review from ulrikstrid October 3, 2025 14:14
@acid-bong
Copy link
Contributor

acid-bong commented Oct 3, 2025

in the title (both commit and PR), you must specify full attr path to the package (ocamlPackages.synchronizer), so that it's clear

  1. for us to see, what you submit, and
  2. for CI to know what exactly to build

@redianthus redianthus changed the title synchronizer: init at 0.1 ocamlPackages.synchronizer: init at 0.1 Oct 3, 2025
@redianthus
Copy link
Member Author

redianthus commented Oct 3, 2025

Thanks, I fixed it.

acid-bong
acid-bong reviewed Oct 3, 2025
View reviewed changes
@acid-bong
Copy link
Contributor

acid-bong commented Oct 3, 2025

and ofc squash them to your init commit

@redianthus
Copy link
Member Author

redianthus commented Oct 3, 2025

Done.

acid-bong
acid-bong approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@acid-bong acid-bong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it's safe to approve now, the package seems to be simple enough. thank you for the contribution and good luck nixing

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 3, 2025
@redianthus
Copy link
Member Author

redianthus commented Oct 3, 2025

Thanks! :)

vbgl
vbgl reviewed Oct 6, 2025
View reviewed changes
@vbgl vbgl added this pull request to the merge queue Oct 7, 2025
Merged via the queue into NixOS:master with commit aa0ebc2 Oct 7, 2025
28 of 31 checks passed
superherointj
superherointj reviewed Oct 7, 2025
View reviewed changes
maintainers/maintainer-list.nix
githubId = 77415970;
name = "Redhawk";
};
redianthus = {
Copy link
Contributor

@superherointj superherointj Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email and name are missing.

The name is important because since people are going to trust your code, we should at least know who you are.

redianthus I did try to contact you over e-mail but since it wasn't available it wasn't possible.

You have requested to join OCaml team at GitHub, unfortunately I have lost my authorization access (can't generate security tokens) to GitHub. So I'm unable to grant you access until I'm able to recover my credential. Also, if you want to join the OCaml team, I think, you should consider adding yourself to the OCaml team here.

@redianthus redianthus mentioned this pull request Oct 7, 2025
Merged
@wolfgangwalther wolfgangwalther mentioned this pull request Oct 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbgl vbgl vbgl left review comments

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

+2 more reviewers

@superherointj superherointj superherointj left review comments

@acid-bong acid-bong acid-bong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@redianthus @acid-bong @vbgl @superherointj