Skip to content

opencollada-blender: fix build with cmake 4#446603

Merged
LordGrimmauld merged 2 commits intoNixOS:masterfrom
LordGrimmauld:opencollada-blender-cmake
Sep 27, 2025
Merged

opencollada-blender: fix build with cmake 4#446603
LordGrimmauld merged 2 commits intoNixOS:masterfrom
LordGrimmauld:opencollada-blender-cmake

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Sep 27, 2025 •
edited
Loading

Fixed the homepage url too, it now actually points to the fork repo.

Part of #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@LordGrimmauld LordGrimmauld marked this pull request as draft September 27, 2025 10:04
@LordGrimmauld LordGrimmauld force-pushed the opencollada-blender-cmake branch from 2bddff3 to 4fa5597 Compare September 27, 2025 10:07
@LordGrimmauld LordGrimmauld marked this pull request as ready for review September 27, 2025 10:07
@LordGrimmauld
Copy link
Contributor Author

LordGrimmauld commented Sep 27, 2025

Tested the build both on master and staging-next, builds fine both with cmake 4 and cmake 3.31

@LordGrimmauld LordGrimmauld mentioned this pull request Sep 27, 2025
Open
@nix-owners nix-owners bot requested a review from amarshall September 27, 2025 10:11
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Sep 27, 2025
@LordGrimmauld LordGrimmauld requested a review from K900 September 27, 2025 10:27
@grimmauld-bot
Copy link

grimmauld-bot commented Sep 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 446603
Commit: 4fa55979560cd591f6f7b32e080c1b90ed1a8021

aarch64-linux

✅ 3 packages built:
  • blender
  • blendfarm
  • opencollada-blender

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 27, 2025
@LordGrimmauld LordGrimmauld added this pull request to the merge queue Sep 27, 2025
Merged via the queue into NixOS:master with commit a7281a9 Sep 27, 2025
35 of 37 checks passed
@LordGrimmauld LordGrimmauld deleted the opencollada-blender-cmake branch September 27, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova approved these changes

@amarshall amarshall Awaiting requested review from amarshall

@K900 K900 Awaiting requested review from K900

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LordGrimmauld @grimmauld-bot @LunNova