Merged
Conversation
13 tasks
LordGrimmauld
force-pushed
the
fltk_clean_2
branch
from
31b0a6e to
ee74af0
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 101-500
LordGrimmauld
force-pushed
the
fltk_clean_2
branch
4 times, most recently
from
7104c05 to
125ea0c
Compare
Contributor
Author
|
okay, now i am done (and i think ofborg died again....) |
eljamm
reviewed
Sep 26, 2025
Release notes: https://github.com/fltk/fltk/releases/tag/release-1.3.11 Fixes build with cmake 4
LordGrimmauld
force-pushed
the
fltk_clean_2
branch
from
125ea0c to
29b522a
Compare
|
eljamm
approved these changes
Sep 26, 2025
Contributor
eljamm
left a comment
eljamm
left a comment
There was a problem hiding this comment.
Diff LGTM. I think it would be better to rebase and clean up the commits a bit, though, as per the commit conventions.
Contributor
Author
|
Hm? Each of these commits is one distinct change, squashing them together will make the changes less atomic. |
Contributor
Author
|
Like, each commit here is not a fix of a previous change (which should be squashed), but its own distinct unit. |
Contributor
|
|
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
|
But it doesn't touch cmake flags? Yeah no, i think it is more logical as is. |
|
Contributor
|
Contributor
Author
|
gmsh has a tendency to oom during build, seeing as the log doesn't have a real error i assume that is what happened here |
Contributor
|
The issue is with the sandbox on Darwin, which we've encountered in the last PR. I'm running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib.cmakeBool--replacewith--replace-failOpenGL_GL_PREFERENCEin 1.4, pango support in 1.3 because 1.3 does not support pango)Follow-up of #401257
Part of #445447, fixes
fltkwith cmake 4Tested by building and running
fltk-versionsonx86_64-linux, both forcing x11 and seeing it default to wayland if available.Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.