Skip to content

gl2ps: fix build with cmake v4#446287

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
qbisi:gl2ps
Sep 27, 2025
Merged

gl2ps: fix build with cmake v4#446287
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
qbisi:gl2ps

Conversation

@qbisi
Copy link
Contributor

@qbisi qbisi commented Sep 26, 2025

Fix build with cmake v4 using a simple substitution. Tested on staging-next branch.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Sep 26, 2025
@nix-owners nix-owners bot requested review from 7c6f434c and twhitehead September 26, 2025 09:35
twhitehead
twhitehead reviewed Sep 26, 2025
View reviewed changes
Copy link
Contributor

@twhitehead twhitehead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine with me. I don't think anything is currently attempting to build it with cmake 4 though (nativeBuildInputs in master is showing cmake-3.31.7), so I can't really comment on that.

Doesn't seem to break any of the current builds though.

@qbisi
Copy link
Contributor Author

qbisi commented Sep 26, 2025

This seems fine with me. I don't think anything is currently attempting to build it with cmake 4 though (nativeBuildInputs in master is showing cmake-3.31.7), so I can't really comment on that.

cmake v4 upgrade has been merged to staging-next, see #394444.
The purpose of this pr is to fix the dependency failure of vtk on staging-next branch.

@qbisi
Copy link
Contributor Author

qbisi commented Sep 26, 2025

Maybe we should open a issue to upstream https://gitlab.onelab.info/gl2ps/gl2ps.
Not sure if upstream have plan to upgrade cmake minumal version required.

twhitehead
twhitehead approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@twhitehead twhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I got it now. It is definitely not building under staging-next as you noted. This looks good to me. Thanks for the fix and explanation!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 26, 2025
@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Sep 27, 2025
Merged via the queue into NixOS:master with commit 5973fae Sep 27, 2025
33 of 35 checks passed
@LordGrimmauld LordGrimmauld mentioned this pull request Sep 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

1 more reviewer

@twhitehead twhitehead twhitehead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qbisi @twhitehead @SuperSandro2000