Skip to content

[staging-next] CMake 4 fixes for docker-tini, openhmd#445579

Merged
vcunat merged 3 commits intoNixOS:staging-nextfrom
LunNova:push-oxoytqrzomkw
Sep 27, 2025
Merged

[staging-next] CMake 4 fixes for docker-tini, openhmd#445579
vcunat merged 3 commits intoNixOS:staging-nextfrom
LunNova:push-oxoytqrzomkw

Conversation

@LunNova
Copy link
Member

@LunNova LunNova commented Sep 23, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: docker tools Open-source software for deploying and running of containerized applications labels Sep 23, 2025
@LunNova
Copy link
Member Author

LunNova commented Sep 23, 2025 •
edited
Loading

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 445579
Commit: 3a3d97eba636d490644dcac645e5adda5f0ddff0

x86_64-linux

✅ 22 packages built:
  • airlift
  • airlift.dist
  • charliecloud
  • devcontainer
  • docker (docker_28)
  • docker-gc
  • docker-language-server
  • docker-sbom
  • docker-vackup
  • docker_25
  • envision
  • fn-cli
  • gefyra
  • monado
  • openhmd
  • pipework
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
  • python313Packages.jupyter-repo2docker
  • python313Packages.jupyter-repo2docker.dist
  • tests.devShellTools.nixos
  • wrkflw

@LunNova

This comment was marked as outdated.

Sign in to view
@LunNova
docker-tini: s/init/tini/ in pname
77c4074 
docker-tini's pname was docker-init which was confusing since
there's a top level docker-init package, and the attr here is
docker-tini
@LunNova
docker-tini: bump for CMake 4 compat
ace81c5 
diff: krallin/tini@v0.19.0...369448a

Changes since last tag are small and CMake 4 commit doesn't
backport cleanly so let's bump.
@LunNova
openhmd: fix CMake 4 build
3a3d97e 
openhmd is unmaintained so substituting for CMake 4 compat

See NixOS#445575 to decide if something should be done about OpenHMD being
unmaintained
@LunNova

This comment was marked as resolved.

Sign in to view
@LordGrimmauld LordGrimmauld mentioned this pull request Sep 24, 2025
Open
@vcunat vcunat merged commit 99bcf8c into NixOS:staging-next Sep 27, 2025
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teutat3s teutat3s Awaiting requested review from teutat3s

@periklis periklis Awaiting requested review from periklis

@oxij oxij Awaiting requested review from oxij

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

No one assigned

Labels

6.topic: docker tools Open-source software for deploying and running of containerized applications 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LunNova @vcunat