thrift: 0.18.1 -> 0.22.0 + clean#445433
Merged
GaetanLepage merged 5 commits intoNixOS:staging-nextfrom Sep 26, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
nixpkgs-ci
bot
added
the
9.needs: reviewer
I'm fetching from Github instead of the apache server since the release from apache.org appears to be missing the file "lib/cpp/test/Thrift5272.thrift". As such, it will not build. For reasons that are unclear, the mirror on github appears to have that file and will build. I remove all the patches since it appears to build on aarch64-darwin without the patches. I removed the disabled tests since it appears to build on aarch64-darwin (sandbox = true) without those tests being disabled.
logs did contain ``` thrift> -- Build shared libraries: OFF ``` And upstream README in lib/cpp says: ``` THRIFT-4732: The CMake build options WITH_SHARED_LIBS and WITH_STATIC_LIBS are deprecated. The project no longer performs a side-by-side static and shared build; you tell CMake through BUILD_SHARED_LIBS whether to make shared or static libraries now. This is CMake standard behavior. ```
nixpkgs-ci
bot
removed
the
9.needs: reviewer
nim65s
force-pushed
the
cmake4-thrift
branch
from
8450798 to
c9041ae
Compare
Contributor
Author
|
retargeted to staging next, thanks @vcunat |
leona-ya
approved these changes
Sep 24, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
GaetanLepage
approved these changes
Sep 26, 2025
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #374710 but without removing disabledTests, because as seen in #444660, they were just not running.
cc @DaGenix @emilazy
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.